AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[build][torque] include src/globals.h in Torque

Browse Source 
Bug: v8:8863
Change-Id: I8907b7b0b7dfa53a2e1e607c0bad26939d312f4e
Reviewed-on: https://chromium-review.googlesource.com/c/1485836
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59816}
This commit is contained in:
Tobias Tebbi 2019-02-25 11:32:56 +01:00 committed by Commit Bot
parent 79e60c9382
commit 05715e53a0
4 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
BUILD.gn
View File

@ -1552,6 +1552,20 @@ v8_header_set("v8_headers") {
]
}
# This is split out to share basic headers with Torque.
v8_header_set("v8_shared_internal_headers") {
visibility = [ ":*" ] # Only targets in this file can depend on this.
configs = [ ":internal_config" ]
sources = [
"src/globals.h",
]
deps = [
":v8_headers",
]
}
v8_source_set("v8_base") {
visibility = [ ":*" ] # Only targets in this file can depend on this.
@ -2030,7 +2044,6 @@ v8_source_set("v8_base") {
"src/gdb-jit.h",
"src/global-handles.cc",
"src/global-handles.h",
"src/globals.h",
"src/handler-table.cc",
"src/handler-table.h",
"src/handles-inl.h",
@ -3011,6 +3024,7 @@ v8_source_set("v8_base") {
":v8_headers",
":v8_libbase",
":v8_libsampler",
":v8_shared_internal_headers",
":v8_version",
"src/inspector:inspector",
]
@ -3121,6 +3135,7 @@ v8_source_set("torque_base") {
deps = [
":v8_libbase",
":v8_shared_internal_headers",
]
configs = [ ":internal_config" ]

1
src/torque/csa-generator.cc
View File

@ -4,6 +4,7 @@
#include "src/torque/csa-generator.h"
#include "src/globals.h"
#include "src/torque/type-oracle.h"
#include "src/torque/utils.h"

1
src/torque/implementation-visitor.cc
View File

@ -4,6 +4,7 @@
#include <algorithm>
#include "src/globals.h"
#include "src/torque/csa-generator.h"
#include "src/torque/declaration-visitor.h"
#include "src/torque/implementation-visitor.h"

2
src/torque/utils.h
View File

@ -270,8 +270,6 @@ class ToString {
std::stringstream s_;
};
constexpr int kTaggedSize = sizeof(void*);
static const char* const kBaseNamespaceName = "base";
static const char* const kTestNamespaceName = "test";
static const char* const kConstructMethodName = "constructor";