From 05813641db40cd7aa7dcaffe2f169933b4d87ed8 Mon Sep 17 00:00:00 2001 From: Jakob Kummerow Date: Sat, 13 Nov 2021 01:21:56 +0100 Subject: [PATCH] [wasm-gc] Enable speculative inlining when GC is enabled This makes --experimental-wasm-gc imply --wasm-speculative-inlining, which in turn implies --wasm-inlining and --wasm-dynamic-tiering as prerequisites. The former implication is weak, i.e. can be overridden on the command line. Bug: v8:7748 Change-Id: Iedc7c9916947f26e17bdd29dbf3b413dbaa05e6c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3275571 Reviewed-by: Manos Koukoutos Commit-Queue: Jakob Kummerow Cr-Commit-Position: refs/heads/main@{#77944} --- src/flags/flag-definitions.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/flags/flag-definitions.h b/src/flags/flag-definitions.h index 7c4d0faa6a..1ffbbb7f93 100644 --- a/src/flags/flag-definitions.h +++ b/src/flags/flag-definitions.h @@ -1092,8 +1092,9 @@ DEFINE_BOOL(trace_wasm_inlining, false, "trace wasm inlining") DEFINE_BOOL(trace_wasm_speculative_inlining, false, "trace wasm speculative inlining") DEFINE_IMPLICATION(wasm_speculative_inlining, experimental_wasm_typed_funcref) +DEFINE_IMPLICATION(wasm_speculative_inlining, wasm_dynamic_tiering) DEFINE_IMPLICATION(wasm_speculative_inlining, wasm_inlining) -DEFINE_NEG_IMPLICATION(wasm_speculative_inlining, wasm_tier_up) +DEFINE_WEAK_IMPLICATION(experimental_wasm_gc, wasm_speculative_inlining) DEFINE_BOOL(wasm_loop_unrolling, true, "enable loop unrolling for wasm functions") DEFINE_BOOL(wasm_fuzzer_gen_test, false,