AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[compiler] Remove --turbo-...-ispendingallocation flag

Browse Source 
No longer needed now that the predicate is fixed.

Bug: v8:7790,v8:11779
Change-Id: If585c3692aed77659b53f670182129988ba93130
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996193
Auto-Submit: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Georg Neis <neis@chromium.org>
Reviewed-by: Georg Neis <neis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#75486}
This commit is contained in:
Jakob Gruber 2021-06-30 13:22:15 +02:00 committed by V8 LUCI CQ
parent 977a2761eb
commit 0585ada4c0
2 changed files with 5 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/compiler/heap-refs.cc
View File

@ -2809,16 +2809,11 @@ ObjectData* JSHeapBroker::TryGetOrCreateData(Handle<Object> object,
const bool crash_on_error = (flags & kCrashOnError) != 0;
// TODO(jgruber): Remove this flag check (and the flag) once TSAN failures
// are fixed.
// See also: crbug.com/v8/11779
if (FLAG_turbo_concurrent_inlining_check_ispendingallocation) {
if ((flags & kAssumeMemoryFence) == 0 &&
ObjectMayBeUninitialized(HeapObject::cast(*object))) {
TRACE_BROKER_MISSING(this, "Object may be uninitialized " << *object);
CHECK_WITH_MSG(!crash_on_error, "Ref construction failed");
return nullptr;
}
if ((flags & kAssumeMemoryFence) == 0 &&
ObjectMayBeUninitialized(HeapObject::cast(*object))) {
TRACE_BROKER_MISSING(this, "Object may be uninitialized " << *object);
CHECK_WITH_MSG(!crash_on_error, "Ref construction failed");
return nullptr;
}
if (IsReadOnlyHeapObjectForCompiler(HeapObject::cast(*object))) {

3
src/flags/flag-definitions.h
View File

@ -711,9 +711,6 @@ DEFINE_WEAK_VALUE_IMPLICATION(stress_concurrent_inlining, interrupt_budget,
DEFINE_BOOL(
turbo_concurrent_get_property_access_info, false,
"concurrently call GetPropertyAccessInfo (only with --concurrent-inlining)")
DEFINE_BOOL(turbo_concurrent_inlining_check_ispendingallocation, true,
"when --concurrent-inlining is enabled, check IsPendingAllocation "
"in Ref construction")
DEFINE_INT(max_serializer_nesting, 25,
"maximum levels for nesting child serializers")
DEFINE_WEAK_IMPLICATION(future, concurrent_inlining)