AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[x86] Blacklist AVX for all Mac OS versions up to 10.9.

Browse Source 
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/808333005

Cr-Commit-Position: refs/heads/master@{#25969}
This commit is contained in:
Benedikt Meurer 2015-01-07 13:10:44 +01:00
parent b2378c7404
commit 05bcc2fbc6
2 changed files with 16 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/ia32/assembler-ia32.cc
View File

@ -58,8 +58,8 @@ namespace {
bool EnableAVX() {
#if V8_OS_MACOSX
// Mac OS X 10.9 has a bug where AVX transitions were indeed being caused by
// ISRs, so we detect Mac OS X 10.9 here and disable AVX in that case.
// Mac OS X up to 10.9 has a bug where AVX transitions were indeed being
// caused by ISRs, so we detect that here and disable AVX in that case.
char buffer[128];
size_t buffer_size = arraysize(buffer);
int ctl_name[] = { CTL_KERN , KERN_OSRELEASE };
@ -67,9 +67,12 @@ bool EnableAVX() {
V8_Fatal(__FILE__, __LINE__, "V8 failed to get kernel version");
}
// The buffer now contains a string of the form XX.YY.ZZ, where
// XX is the major kernel version component. 13.x.x (Mavericks) is
// affected by this bug, so disable AVX there.
if (memcmp(buffer, "13.", 3) == 0) return false;
// XX is the major kernel version component.
char* period_pos = strchr(buffer, '.');
DCHECK_NOT_NULL(period_pos);
*period_pos = '\0';
long kernel_version_major = strtol(buffer, nullptr, 10); // NOLINT
if (kernel_version_major <= 13) return false;
#endif // V8_OS_MACOSX
return FLAG_enable_avx;
}

13
src/x64/assembler-x64.cc
View File

@ -24,8 +24,8 @@ namespace {
bool EnableAVX() {
#if V8_OS_MACOSX
// Mac OS X 10.9 has a bug where AVX transitions were indeed being caused by
// ISRs, so we detect Mac OS X 10.9 here and disable AVX in that case.
// Mac OS X up to 10.9 has a bug where AVX transitions were indeed being
// caused by ISRs, so we detect that here and disable AVX in that case.
char buffer[128];
size_t buffer_size = arraysize(buffer);
int ctl_name[] = { CTL_KERN , KERN_OSRELEASE };
@ -33,9 +33,12 @@ bool EnableAVX() {
V8_Fatal(__FILE__, __LINE__, "V8 failed to get kernel version");
}
// The buffer now contains a string of the form XX.YY.ZZ, where
// XX is the major kernel version component. 13.x.x (Mavericks) is
// affected by this bug, so disable AVX there.
if (memcmp(buffer, "13.", 3) == 0) return false;
// XX is the major kernel version component.
char* period_pos = strchr(buffer, '.');
DCHECK_NOT_NULL(period_pos);
*period_pos = '\0';
long kernel_version_major = strtol(buffer, nullptr, 10); // NOLINT
if (kernel_version_major <= 13) return false;
#endif // V8_OS_MACOSX
return FLAG_enable_avx;
}