From 06f1864aebefefc63c2823f21c8cb90ce3ce29d6 Mon Sep 17 00:00:00 2001 From: Michael Achenbach Date: Tue, 12 Nov 2019 13:13:15 +0100 Subject: [PATCH] [test] Simplify test exceptions for force-slow-path This allows the tests to continue running on the gc fuzzers while staying compatible with the --force-slow-path flag being passed randomly. When run in slow_path variants these tests are no-ops, but that's negligible as the tests are also fast without slow_path. Change-Id: I461c47b669b163e1e1594ea1a941f63e90f2221e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1910947 Reviewed-by: Jakob Gruber Reviewed-by: Clemens Backes Commit-Queue: Michael Achenbach Cr-Commit-Position: refs/heads/master@{#64914} --- test/mjsunit/filter-element-kinds.js | 1 + test/mjsunit/mjsunit.status | 18 ------------------ test/mjsunit/regress/regress-crbug-493779.js | 2 +- test/mjsunit/regress/wasm/regress-9759.js | 2 +- test/mjsunit/string-replace-gc.js | 2 +- test/mjsunit/wasm/stack.js | 2 +- 6 files changed, 5 insertions(+), 22 deletions(-) diff --git a/test/mjsunit/filter-element-kinds.js b/test/mjsunit/filter-element-kinds.js index 24dd31a5d1..f3243e9393 100644 --- a/test/mjsunit/filter-element-kinds.js +++ b/test/mjsunit/filter-element-kinds.js @@ -26,6 +26,7 @@ // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. // Flags: --allow-natives-syntax --expose-gc --opt --no-always-opt +// Flags: --no-force-slow-path var elements_kind = { fast_smi_only : 'fast smi only elements', diff --git a/test/mjsunit/mjsunit.status b/test/mjsunit/mjsunit.status index d7c5539641..9f55e89f27 100644 --- a/test/mjsunit/mjsunit.status +++ b/test/mjsunit/mjsunit.status @@ -1057,24 +1057,6 @@ 'wasm/tier-up-testing-flag': [SKIP], }], # arch != x64 and arch != ia32 and arch != arm64 and arch != arm -############################################################################## -['variant == slow_path and gc_stress', { - # Slow tests. - 'regress/regress-crbug-493779': [SKIP], - 'string-replace-gc': [SKIP], -}], # variant == slow_path and gc_stress - -############################################################################## -['variant == slow_path', { - # Slow tests doing too many array manipulations each of which takes slow - # path usually through a runtime call. - 'regress/wasm/regress-9759': [SKIP], - 'wasm/stack': [SKIP], - - # Tests that are not compatible with the --force-slow-path mode. - 'filter-element-kinds': [SKIP], -}], # variant == slow_path - ############################################################################## ['arch not in [x64, arm, arm64] or system != linux', { # Unwinding info writer is only supported on x64, arm, and arm64 Linux diff --git a/test/mjsunit/regress/regress-crbug-493779.js b/test/mjsunit/regress/regress-crbug-493779.js index 1071ed23ac..3a5f1cfa53 100644 --- a/test/mjsunit/regress/regress-crbug-493779.js +++ b/test/mjsunit/regress/regress-crbug-493779.js @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --enable-slow-asserts +// Flags: --enable-slow-asserts --no-force-slow-path var s = "\u1234-------"; for (var i = 0; i < 17; i++) { diff --git a/test/mjsunit/regress/wasm/regress-9759.js b/test/mjsunit/regress/wasm/regress-9759.js index 9d1f86a48d..0054ad183e 100644 --- a/test/mjsunit/regress/wasm/regress-9759.js +++ b/test/mjsunit/regress/wasm/regress-9759.js @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --no-wasm-tier-up --no-liftoff +// Flags: --no-wasm-tier-up --no-liftoff --no-force-slow-path load("test/mjsunit/wasm/wasm-module-builder.js"); diff --git a/test/mjsunit/string-replace-gc.js b/test/mjsunit/string-replace-gc.js index 56b6a09da1..7b2c7177c6 100644 --- a/test/mjsunit/string-replace-gc.js +++ b/test/mjsunit/string-replace-gc.js @@ -27,7 +27,7 @@ // Regression test for the r1513 fix. -// Flags: --allow-natives-syntax +// Flags: --allow-natives-syntax --no-force-slow-path var foo = "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"; assertEquals(39, foo.length); diff --git a/test/mjsunit/wasm/stack.js b/test/mjsunit/wasm/stack.js index cc1f1005ba..d6ae8541a6 100644 --- a/test/mjsunit/wasm/stack.js +++ b/test/mjsunit/wasm/stack.js @@ -2,7 +2,7 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// Flags: --expose-wasm +// Flags: --expose-wasm --no-force-slow-path load("test/mjsunit/wasm/wasm-module-builder.js");