[arm][arm64] Fix TurboAssembler tests for hard aborts

The tests were not flushing the i-cache before calling the generated
code. Use Factory::NewCode to make sure that the i-cache is flushed
instead.

Bug: v8:7977
Change-Id: I9c7c6f0d0e31700634e50279e75858a5d74603d8
Reviewed-on: https://chromium-review.googlesource.com/1150165
Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
Commit-Queue: Georgia Kouveli <georgia.kouveli@arm.com>
Cr-Commit-Position: refs/heads/master@{#54711}
This commit is contained in:
Georgia Kouveli 2018-07-25 17:45:44 +01:00 committed by Commit Bot
parent 9e3d6cbec5
commit 079eee4387
2 changed files with 3 additions and 6 deletions

View File

@ -27,6 +27,9 @@ static inline void MakeAssemblerBufferExecutable(uint8_t* buffer,
bool result = v8::internal::SetPermissions(buffer, allocated,
v8::PageAllocator::kReadExecute);
CHECK(result);
// Flush the instruction cache as part of making the buffer executable.
Assembler::FlushICache(buffer, allocated);
}
static inline void MakeAssemblerBufferWritable(uint8_t* buffer,

View File

@ -15,10 +15,4 @@
'RandomNumberGenerator.NextSampleSlowInvalidParam1': [SKIP],
'RandomNumberGenerator.NextSampleSlowInvalidParam2': [SKIP],
}], # 'system == macos and asan'
['arch == arm and not simulator_run', {
# Crashes flakily: https://crbug.com/v8/7977
'TurboAssemblerTest.TestCheck': [SKIP],
}], # arch == arm and not simulator_run
]