AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[turbofan] simplified lowering: process DeadValue input

Browse Source 
Without processing the input, a phi node can be flagged as unused and
replaced with {Dead}, although it is used by a {DeadValue} node.

Bug: chromium:808472
Change-Id: I7446883535b34770e31e4e26e1c242eb05673a91
Reviewed-on: https://chromium-review.googlesource.com/919362
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Reviewed-by: Jaroslav Sevcik <jarin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#51395}
This commit is contained in:
Tobias Tebbi 2018-02-20 15:39:55 +01:00 committed by Commit Bot
parent 252e8a1c2d
commit 07abe39aed
3 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/compiler/simplified-lowering.cc
View File

@ -3060,6 +3060,7 @@ class RepresentationSelector {
// Assume the output is tagged. // Assume the output is tagged.
return SetOutput(node, MachineRepresentation::kTagged); return SetOutput(node, MachineRepresentation::kTagged);
case IrOpcode::kDeadValue: case IrOpcode::kDeadValue:
ProcessInput(node, 0, UseInfo::Any());
return SetOutput(node, MachineRepresentation::kNone); return SetOutput(node, MachineRepresentation::kNone);
default: default:
FATAL( FATAL(

12
test/mjsunit/compiler/regress-808472.js Normal file
View File

@ -0,0 +1,12 @@
// Copyright 2018 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
function opt() {
let opt, arr = [...[...[...[...new Uint8Array(0x10000)]]]];
while (arr--) {
opt = ((typeof opt) === 'undefined') ? /a/ : arr;
}
}
opt();
opt();

1
test/mjsunit/mjsunit.status
View File

@ -104,6 +104,7 @@
'generated-transition-stub': [PASS, ['mode == debug', SKIP]], 'generated-transition-stub': [PASS, ['mode == debug', SKIP]],
'migrations': [SKIP], 'migrations': [SKIP],
'array-functions-prototype-misc': [PASS, SLOW, ['mode == debug', SKIP]], 'array-functions-prototype-misc': [PASS, SLOW, ['mode == debug', SKIP]],
'compiler/regress-808472': [PASS, ['mode == debug', SKIP]],
############################################################################## ##############################################################################
# This test sets the umask on a per-process basis and hence cannot be # This test sets the umask on a per-process basis and hence cannot be