Explicitly include defaults.cc in the shared_library gyp target.
Explicitly include defaults.cc in the shared_library gyp target, otherwise the whole compilation unit is stripped by the Windows linker, since none of it's symbols are referenced by any other compilation unit in V8. BUG=None R=jkummerow@chromium.org Review URL: https://codereview.chromium.org/25994002 Patch from Ross McIlroy <rmcilroy@chromium.org>. git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@17107 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
parent
7d456285d3
commit
07b15bdfc1
@ -25,6 +25,9 @@
|
||||
// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
||||
// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
||||
|
||||
// The GYP based build ends up defining USING_V8_SHARED when compiling this
|
||||
// file.
|
||||
#undef USING_V8_SHARED
|
||||
#include "../include/v8-defaults.h"
|
||||
|
||||
#include "platform.h"
|
||||
|
@ -61,6 +61,10 @@
|
||||
# Note: on non-Windows we still build this file so that gyp
|
||||
# has some sources to link into the component.
|
||||
'../../src/v8dll-main.cc',
|
||||
'../../src/defaults.cc',
|
||||
],
|
||||
'include_dirs': [
|
||||
'../../include',
|
||||
],
|
||||
'defines': [
|
||||
'V8_SHARED',
|
||||
|
Loading…
Reference in New Issue
Block a user