AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "Ship BigInts"

Browse Source 
This reverts commit 16aecc5d9b.

Reason for revert: Breaks several layout tests:
https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/22624

Original change's description:
> Ship BigInts
> 
> Intent to ship:
> https://groups.google.com/d/msg/v8-users/ShhW0Xewph0/1-OT9q0_DQAJ
> 
> Bug: v8:6791
> Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
> Change-Id: Ibcf5ac09c0099496ef2c6a3c23bef9f9e72658f1
> Reviewed-on: https://chromium-review.googlesource.com/981596
> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
> Reviewed-by: Mathias Bynens <mathias@chromium.org>
> Reviewed-by: Adam Klein <adamk@chromium.org>
> Reviewed-by: Georg Neis <neis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#52256}

TBR=adamk@chromium.org,jkummerow@chromium.org,neis@chromium.org,mathias@chromium.org

Change-Id: I32e9f32b501cb72aa364e89d5b2210c0861c68fc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: v8:6791
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/983293
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#52261}
This commit is contained in:
Michael Achenbach 2018-03-28 08:33:42 +00:00 committed by Commit Bot
parent b2f0d8617b
commit 08090db74b
3 changed files with 3 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/flag-definitions.h
View File

@ -222,6 +222,7 @@ DEFINE_IMPLICATION(harmony_class_fields, harmony_private_fields)
"constructor") \
V(harmony_public_fields, "harmony public fields in class literals") \
V(harmony_private_fields, "harmony private fields in class literals") \
V(harmony_bigint, "harmony arbitrary precision integers") \
V(harmony_numeric_separator, "harmony numeric separator between digits")
// Features that are shipping (turned on by default, but internal flag remains).
@ -235,7 +236,6 @@ DEFINE_IMPLICATION(harmony_class_fields, harmony_private_fields)
V(harmony_promise_finally, "harmony Promise.prototype.finally") \
V(harmony_optional_catch_binding, "allow omitting binding in catch blocks") \
V(harmony_import_meta, "harmony import.meta property") \
V(harmony_bigint, "harmony arbitrary precision integers") \
V(harmony_dynamic_import, "harmony dynamic import")
#ifdef V8_INTL_SUPPORT

9
test/debugger/debug/side-effect/debug-evaluate-no-side-effect-builtins.js
View File

@ -99,13 +99,8 @@ function listener(event, exec_state, event_data, data) {
success(undefined, `data_view.byteLength`);
success(undefined, `data_view.byteOffset`);
for (f of Object.getOwnPropertyNames(DataView.prototype)) {
if (typeof data_view[f] === 'function') {
if (f.startsWith('getBig')) {
success(0n, `data_view.${f}()`);
} else if (f.startsWith('get')) {
success(0, `data_view.${f}()`);
}
}
if (typeof data_view[f] === 'function' && f.startsWith('get'))
success(0, `data_view.${f}()`);
}
// Test TypedArray functions.

13
test/test262/test262.status
View File

@ -391,19 +391,6 @@
'built-ins/TypedArray/prototype/set/typedarray-arg-set-values-same-buffer-same-type-sab': ['--harmony-sharedarraybuffer'],
'built-ins/TypedArrays/internals/Get/indexed-value-sab': ['--harmony-sharedarraybuffer'],
# 64-bit Atomics are not implemented yet.
'built-ins/Atomics/wake/bad-range': ['--noharmony-bigint'],
'built-ins/Atomics/xor/bad-range': ['--noharmony-bigint'],
'built-ins/Atomics/load/bad-range': ['--noharmony-bigint'],
'built-ins/Atomics/compareExchange/bad-range': ['--noharmony-bigint'],
'built-ins/Atomics/wait/bad-range': ['--noharmony-bigint'],
'built-ins/Atomics/exchange/bad-range': ['--noharmony-bigint'],
'built-ins/Atomics/sub/bad-range': ['--noharmony-bigint'],
'built-ins/Atomics/store/bad-range': ['--noharmony-bigint'],
'built-ins/Atomics/or/bad-range': ['--noharmony-bigint'],
'built-ins/Atomics/and/bad-range': ['--noharmony-bigint'],
'built-ins/Atomics/add/bad-range': ['--noharmony-bigint'],
# https://bugs.chromium.org/p/v8/issues/detail?id=6049
'built-ins/Object/internals/DefineOwnProperty/consistent-value-function-caller': [FAIL_SLOPPY],
'built-ins/Object/internals/DefineOwnProperty/consistent-value-function-arguments': [FAIL_SLOPPY],