From 085a445775371cddc30c16840a2056cb0944b369 Mon Sep 17 00:00:00 2001 From: kozyatinskiy Date: Mon, 10 Oct 2016 12:08:23 -0700 Subject: [PATCH] [inspector] fix minor issue in test/inspector.gyp * Inspector should depend on v8_libbase, v8 depedency is added in conditions section. * Inlined sources since they aren't used outside of this gyp file. BUG=chromium:635948 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2408833002 Cr-Commit-Position: refs/heads/master@{#40139} --- test/inspector/inspector.gyp | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/test/inspector/inspector.gyp b/test/inspector/inspector.gyp index 3912869606..6d94370ddd 100644 --- a/test/inspector/inspector.gyp +++ b/test/inspector/inspector.gyp @@ -5,13 +5,6 @@ { 'variables': { 'v8_code': 1, - 'inspector_protocol_sources': [ - 'inspector-impl.cc', - 'inspector-impl.h', - 'inspector-test.cc', - 'task-runner.cc', - 'task-runner.h', - ], }, 'includes': ['../../gypfiles/toolchain.gypi', '../../gypfiles/features.gypi'], 'targets': [ @@ -20,13 +13,17 @@ 'type': 'executable', 'dependencies': [ '../../src/v8.gyp:v8_libplatform', - '../../src/v8.gyp:v8', + '../../src/v8.gyp:v8_libbase', ], 'include_dirs': [ '../..', ], 'sources': [ - '<@(inspector_protocol_sources)', + 'inspector-impl.cc', + 'inspector-impl.h', + 'inspector-test.cc', + 'task-runner.cc', + 'task-runner.h', ], 'conditions': [ ['component=="shared_library"', {