From 094eddd219df5831587afd4293fefdf0bbe6bd8c Mon Sep 17 00:00:00 2001 From: Jakob Gruber Date: Wed, 13 Apr 2022 11:29:45 +0200 Subject: [PATCH] [turbofan] Unconditionally unpark the thread during the AssembleCodePhase MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The code generator accesses the heap even without --code-comments set: remove the related condition from the UnparkedScopeIfNeeded. Fixed: v8:12794 Change-Id: I0099f22a9382373c4f75538615fbf431c4d71283 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3582389 Commit-Queue: Jakob Linke Auto-Submit: Jakob Linke Reviewed-by: Dominik Inführ Commit-Queue: Dominik Inführ Cr-Commit-Position: refs/heads/main@{#79953} --- src/compiler/pipeline.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/pipeline.cc b/src/compiler/pipeline.cc index c20da3aaf4..cd546fe9c8 100644 --- a/src/compiler/pipeline.cc +++ b/src/compiler/pipeline.cc @@ -3600,7 +3600,7 @@ void PipelineImpl::AssembleCode(Linkage* linkage) { data->BeginPhaseKind("V8.TFCodeGeneration"); data->InitializeCodeGenerator(linkage); - UnparkedScopeIfNeeded unparked_scope(data->broker(), FLAG_code_comments); + UnparkedScopeIfNeeded unparked_scope(data->broker()); Run(); if (data->info()->trace_turbo_json()) {