AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

When cet is disabled, propagate to v8_shell

Browse Source 
Before: when cet is disabled v8_shell is marked with the
cetcompat bit, which breaks the chromium build on cet
machines.

With this CL: v8_shell is not marked as cetcompat unless
v8_enable_cet_shadow_stacks is true.

Bug: chromium:1289318
Change-Id: If8a79ac5288a9a3385bf6b692db566508cca248f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3656146
Commit-Queue: Alex Gough <ajgo@chromium.org>
Reviewed-by: Clemens Backes <clemensb@chromium.org>
Cr-Commit-Position: refs/heads/main@{#80673}
This commit is contained in:
Alex Gough 2022-05-19 17:39:35 -07:00 committed by V8 LUCI CQ
parent e819612aaf
commit 09b7a8b8c4
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
BUILD.gn
View File

@ -6399,6 +6399,10 @@ if (want_v8_shell) {
":internal_config_base",
]
if (is_win && !v8_enable_cet_shadow_stack) {
v8_remove_configs += [ "//build/config/compiler:cet_shadow_stack" ]
}
deps = [
":v8",
":v8_libbase",