AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[turbofan] Turn DCHECK for fixed slot index into a CHECK.

Browse Source 
This is a temporary workaround to ensure that we crash in release mode
instead of running into undefined behavior.

BUG=chromium:444681
LOG=y
R=ishell@chromium.org

Review URL: https://codereview.chromium.org/800713006

Cr-Commit-Position: refs/heads/master@{#25933}
This commit is contained in:
Benedikt Meurer 2014-12-23 12:00:46 +01:00
parent 3f00ce2d59
commit 0a03b5ef18
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/compiler/instruction.h
View File

@ -129,7 +129,8 @@ class UnallocatedOperand : public InstructionOperand {
value_ |= VirtualRegisterField::encode(kInvalidVirtualRegister);
value_ |= BasicPolicyField::encode(policy);
value_ |= index << FixedSlotIndexField::kShift;
DCHECK(this->fixed_slot_index() == index);
// TODO(dcarney): 2^10 is not enough for the fixed slot index.
CHECK(this->fixed_slot_index() == index);
}
UnallocatedOperand(ExtendedPolicy policy, int index)