From 0a7996882e073e0670972e6d2968db17d484fa09 Mon Sep 17 00:00:00 2001 From: yangguo Date: Thu, 22 Oct 2015 07:15:33 -0700 Subject: [PATCH] [es6] stage sticky regexps and RegExp.prototype.flags. R=littledan@chromium.org BUG=v8:4342 LOG=Y Committed: https://crrev.com/722719fe31fe7fd5bb50be6256b3581bb28a8169 Cr-Commit-Position: refs/heads/master@{#31390} Review URL: https://codereview.chromium.org/1412133002 Cr-Commit-Position: refs/heads/master@{#31479} --- src/flag-definitions.h | 10 +++++----- test/test262/test262.status | 20 +++++++------------- 2 files changed, 12 insertions(+), 18 deletions(-) diff --git a/src/flag-definitions.h b/src/flag-definitions.h index 872aea97fe..f1d2ed5e97 100644 --- a/src/flag-definitions.h +++ b/src/flag-definitions.h @@ -190,7 +190,6 @@ DEFINE_BOOL(legacy_const, true, "legacy semantics for const in sloppy mode") // Features that are still work in progress (behind individual flags). #define HARMONY_INPROGRESS(V) \ V(harmony_modules, "harmony modules") \ - V(harmony_regexps, "harmony regular expression extensions") \ V(harmony_proxies, "harmony proxies") \ V(harmony_unicode_regexps, "harmony unicode regexps") \ V(harmony_tolength, "harmony ToLength") \ @@ -203,10 +202,11 @@ DEFINE_BOOL(legacy_const, true, "legacy semantics for const in sloppy mode") V(harmony_do_expressions, "harmony do-expressions") // Features that are complete (but still behind --harmony/es-staging flag). -#define HARMONY_STAGED(V) \ - V(harmony_tostring, "harmony toString") \ - V(harmony_sloppy, "harmony features in sloppy mode") \ - V(harmony_sloppy_let, "harmony let in sloppy mode") \ +#define HARMONY_STAGED(V) \ + V(harmony_regexps, "harmony regular expression extensions") \ + V(harmony_tostring, "harmony toString") \ + V(harmony_sloppy, "harmony features in sloppy mode") \ + V(harmony_sloppy_let, "harmony let in sloppy mode") \ V(harmony_completion, "harmony completion value semantics") // Features that are shipping (turned on by default, but internal flag remains). diff --git a/test/test262/test262.status b/test/test262/test262.status index 01def65725..64bf69e157 100644 --- a/test/test262/test262.status +++ b/test/test262/test262.status @@ -494,25 +494,17 @@ # https://code.google.com/p/v8/issues/detail?id=4342 'built-ins/RegExp/prototype/exec/get-sticky-coerce': [FAIL], 'built-ins/RegExp/prototype/exec/get-sticky-err': [FAIL], - 'built-ins/RegExp/prototype/exec/y-fail-lastindex': [FAIL], - 'built-ins/RegExp/prototype/exec/y-fail-lastindex-no-write': [FAIL], - 'built-ins/RegExp/prototype/exec/y-fail-return': [FAIL], - 'built-ins/RegExp/prototype/exec/y-fail-lastindex': [FAIL], - 'built-ins/RegExp/prototype/exec/y-init-lastindex': [FAIL], - 'built-ins/RegExp/prototype/exec/y-set-lastindex': [FAIL], 'built-ins/RegExp/prototype/sticky/prop-desc': [FAIL], 'built-ins/RegExp/prototype/sticky/this-invalid-obj': [FAIL], 'built-ins/RegExp/prototype/sticky/this-non-obj': [FAIL], - 'built-ins/RegExp/prototype/sticky/this-regexp': [FAIL], 'built-ins/RegExp/prototype/test/get-sticky-coerce': [FAIL], 'built-ins/RegExp/prototype/test/get-sticky-err': [FAIL], - 'built-ins/RegExp/prototype/test/y-fail-lastindex-no-write': [FAIL], - 'built-ins/RegExp/prototype/test/y-fail-return': [FAIL], - 'built-ins/RegExp/prototype/test/y-fail-lastindex': [FAIL], - 'built-ins/RegExp/prototype/test/y-init-lastindex': [FAIL], - 'built-ins/RegExp/prototype/test/y-set-lastindex': [FAIL], 'built-ins/RegExp/valid-flags-y': [FAIL], + # https://code.google.com/p/v8/issues/detail?id=4504 + 'built-ins/RegExp/prototype/exec/y-fail-lastindex-no-write': [PASS, FAIL], + 'built-ins/RegExp/prototype/test/y-fail-lastindex-no-write': [PASS, FAIL], + # https://code.google.com/p/v8/issues/detail?id=4305 # SKIP rather than FAIL some tests, as they may check for an exception which # happens to be thrown for some other reason (e.g, @@ -547,7 +539,9 @@ 'built-ins/String/prototype/split/cstm-split-get-err': [FAIL], # https://code.google.com/p/v8/issues/detail?id=4346 - 'built-ins/RegExp/prototype/flags/*': [FAIL], + 'built-ins/RegExp/prototype/flags/name': [FAIL], + 'built-ins/RegExp/prototype/flags/y-attr-err': [FAIL], + 'built-ins/RegExp/prototype/flags/u': [FAIL], # https://code.google.com/p/v8/issues/detail?id=4347 'built-ins/RegExp/prototype/global/name': [FAIL],