diff --git a/BUILD.gn b/BUILD.gn index 36da2a462f..0798410b7d 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -3388,6 +3388,8 @@ v8_source_set("torque_base") { ] if (is_win && is_asan) { + # Due to a bug in ASAN on Windows (chromium:893437), we disable ASAN for + # Torque on Windows. remove_configs += [ "//build/config/sanitizers:default_sanitizer_flags" ] } diff --git a/src/torque/utils.h b/src/torque/utils.h index dc9a77594c..10b91ce7d4 100644 --- a/src/torque/utils.h +++ b/src/torque/utils.h @@ -232,11 +232,6 @@ class Stack { elements_.at(from_bottom.offset) = std::move(x); } void Push(T x) { - // Manually increasing the std::vector capacity is a workaround for an - // ASAN-container-overflow false positive. - if (elements_.size() == elements_.capacity()) { - elements_.reserve(2 * elements_.size() + 1); - } elements_.push_back(std::move(x)); } StackRange TopRange(size_t slot_count) const { diff --git a/test/unittests/unittests.status b/test/unittests/unittests.status index a105afe987..c36a0b70f8 100644 --- a/test/unittests/unittests.status +++ b/test/unittests/unittests.status @@ -34,4 +34,9 @@ '*': [SKIP], }], # variant == jitless and not embedded_builtins +['system == windows and asan', { + # BUG(893437). + 'Torque*': [SKIP], +}], # 'system == windows and asan' + ]