AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[heap] Fix -Wshadow warnings in src/heap/heap.cc

Browse Source 
Bug: v8:12244, v8:12245
Change-Id: Iaa2d8be352bbe03882f531cc66ab36c15b2b2a75
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3182227
Auto-Submit: Dominik Inführ <dinfuehr@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77051}
This commit is contained in:
Dominik Inführ 2021-09-24 16:29:15 +02:00 committed by V8 LUCI CQ
parent 58249ba601
commit 0ad40c42b7
1 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/heap/heap.cc
View File

@ -792,16 +792,16 @@ void Heap::PrintRetainingPath(HeapObject target, RetainingPathOption option) {
}
int distance = static_cast<int>(retaining_path.size());
for (auto node : retaining_path) {
HeapObject object = node.first;
bool ephemeron = node.second;
HeapObject node_object = node.first;
bool node_ephemeron = node.second;
PrintF("\n");
PrintF("^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\n");
PrintF("Distance from root %d%s: ", distance,
ephemeron ? " (ephemeron)" : "");
object.ShortPrint();
node_ephemeron ? " (ephemeron)" : "");
node_object.ShortPrint();
PrintF("\n");
#ifdef OBJECT_PRINT
object.Print();
node_object.Print();
PrintF("\n");
#endif
--distance;
@ -1179,8 +1179,8 @@ void Heap::ProcessPretenuringFeedback() {
// Step 2: Pretenure allocation sites for manual requests.
if (allocation_sites_to_pretenure_) {
while (!allocation_sites_to_pretenure_->empty()) {
auto site = allocation_sites_to_pretenure_->Pop();
if (PretenureAllocationSiteManually(isolate_, site)) {
auto pretenure_site = allocation_sites_to_pretenure_->Pop();
if (PretenureAllocationSiteManually(isolate_, pretenure_site)) {
trigger_deoptimization = true;
}
}
@ -1776,7 +1776,7 @@ bool Heap::CollectGarbage(AllocationSpace space,
AllowGarbageCollection allow_gc;
AllowJavascriptExecution allow_js(isolate());
TRACE_GC(tracer(), GCTracer::Scope::HEAP_EXTERNAL_PROLOGUE);
VMState<EXTERNAL> state(isolate_);
VMState<EXTERNAL> callback_state(isolate_);
HandleScope handle_scope(isolate_);
CallGCPrologueCallbacks(gc_type, kNoGCCallbackFlags);
}
@ -1812,7 +1812,7 @@ bool Heap::CollectGarbage(AllocationSpace space,
AllowGarbageCollection allow_gc;
AllowJavascriptExecution allow_js(isolate());
TRACE_GC(tracer(), GCTracer::Scope::HEAP_EXTERNAL_EPILOGUE);
VMState<EXTERNAL> state(isolate_);
VMState<EXTERNAL> callback_state(isolate_);
HandleScope handle_scope(isolate_);
CallGCEpilogueCallbacks(gc_type, gc_callback_flags);
}