AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[foozzie] Remove outdated suppressions

Browse Source 
It is obsolete to filter out error-message differences since the
time we pass --correctness-fuzzer-suppressions to d8, which already
stubs all messages:
https://cs.chromium.org/chromium/src/v8/src/execution/messages.cc?l=1031

No-Try: true
Bug: chromium:1100114
Change-Id: Iac42a8e2a32f9bae4034f79eaff429bf3ee41724
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2270024
Reviewed-by: Maya Lekova <mslekova@chromium.org>
Reviewed-by: Tamer Tas <tmrts@chromium.org>
Commit-Queue: Michael Achenbach <machenbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#68577}
This commit is contained in:
Michael Achenbach 2020-06-27 21:57:35 +02:00 committed by Commit Bot
parent c220a05ca9
commit 0b01726bb7
2 changed files with 8 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
tools/clusterfuzz/v8_foozzie_test.py
View File

@ -134,19 +134,19 @@ class UnitTest(unittest.TestCase):
diff = None, None
self.assertEqual(diff, diff_fun(one, two))
# Ignore line before caret, caret position and error message.
# Ignore line before caret and caret position.
one = """
undefined
weird stuff
^
somefile.js: TypeError: undefined is not a function
somefile.js: TypeError: suppressed message
undefined
"""
two = """
undefined
other weird stuff
^
somefile.js: TypeError: baz is not a function
somefile.js: TypeError: suppressed message
undefined
"""
diff = None, None
@ -187,15 +187,16 @@ otherfile.js: TypeError: undefined is not a constructor
# Test that skipping suppressions works.
one = """
v8-foozzie source: foo
23:TypeError: bar is not a function
weird stuff
^
"""
two = """
v8-foozzie source: foo
42:TypeError: baz is not a function
other weird stuff
^
"""
self.assertEqual((None, 'foo'), diff_fun(one, two))
diff = """- 23:TypeError: bar is not a function
+ 42:TypeError: baz is not a function""", 'foo'
diff = ('- ^\n+ ^', 'foo')
self.assertEqual(diff, diff_fun(one, two, skip=True))
def testOutputCapping(self):

20
tools/clusterfuzz/v8_suppressions.py
View File

@ -73,26 +73,6 @@ IGNORE_OUTPUT = {
ALLOWED_LINE_DIFFS = [
# Ignore caret position in stack traces.
r'^\s*\^\s*$',
# Ignore some stack trace headers as messages might not match.
r'^(.*)TypeError: .* is not a function$',
r'^(.*)TypeError: .* is not a constructor$',
r'^(.*)TypeError: (.*) is not .*$',
r'^(.*):\d+: TypeError: Message suppressed for fuzzers.*$',
r'^(.*)ReferenceError: .* is not defined$',
r'^(.*):\d+: ReferenceError: .* is not defined$',
# These are rarely needed. It includes some cases above.
r'^\w*Error: .* is not .*$',
r'^(.*) \w*Error: .* is not .*$',
r'^(.*):\d+: \w*Error: .* is not .*$',
# Some test cases just print the message.
r'^.* is not a function(.*)$',
r'^(.*) is not a .*$',
# crbug.com/680064. This subsumes one of the above expressions.
r'^(.*)TypeError: .* function$',
]
# Lines matching any of the following regular expressions will be ignored.