From 0bca3b45630495fe8b7b73f1844f8f1daf0080bb Mon Sep 17 00:00:00 2001 From: Harshil Jain Date: Fri, 4 Feb 2022 13:45:03 +0530 Subject: [PATCH] [message] Remove deprecated PrintCurrentStackTrace function which take a FILE* Change-Id: I598b3e7b0ad349c504d8729eb288d19b14319253 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3439336 Reviewed-by: Clemens Backes Reviewed-by: Camillo Bruni Auto-Submit: Harshil Jain Commit-Queue: Clemens Backes Cr-Commit-Position: refs/heads/main@{#79074} --- AUTHORS | 1 + include/v8-message.h | 2 -- src/api/api.cc | 8 -------- 3 files changed, 1 insertion(+), 10 deletions(-) diff --git a/AUTHORS b/AUTHORS index 6af2d70089..9ad2949716 100644 --- a/AUTHORS +++ b/AUTHORS @@ -112,6 +112,7 @@ Gus Caplan Gwang Yoon Hwang Haichuan Wang Hannu Trey +Harshil Jain Henrique Ferreiro Hirofumi Mako Honggyu Kim diff --git a/include/v8-message.h b/include/v8-message.h index ae1515d712..a13276412a 100644 --- a/include/v8-message.h +++ b/include/v8-message.h @@ -189,8 +189,6 @@ class V8_EXPORT Message { bool IsSharedCrossOrigin() const; bool IsOpaque() const; - V8_DEPRECATED("Use the version that takes a std::ostream&.") - static void PrintCurrentStackTrace(Isolate* isolate, FILE* out); static void PrintCurrentStackTrace(Isolate* isolate, std::ostream& out); static const int kNoLineNumberInfo = 0; diff --git a/src/api/api.cc b/src/api/api.cc index b043b0104e..230493db4b 100644 --- a/src/api/api.cc +++ b/src/api/api.cc @@ -3119,14 +3119,6 @@ MaybeLocal Message::GetSourceLine(Local context) const { RETURN_ESCAPED(Utils::ToLocal(self->GetSourceLine())); } -void Message::PrintCurrentStackTrace(Isolate* isolate, FILE* out) { - i::Isolate* i_isolate = reinterpret_cast(isolate); - ENTER_V8_NO_SCRIPT_NO_EXCEPTION(i_isolate); - std::ostringstream stack_trace_stream; - i_isolate->PrintCurrentStackTrace(stack_trace_stream); - i::PrintF(out, "%s", stack_trace_stream.str().c_str()); -} - void Message::PrintCurrentStackTrace(Isolate* isolate, std::ostream& out) { i::Isolate* i_isolate = reinterpret_cast(isolate); ENTER_V8_NO_SCRIPT_NO_EXCEPTION(i_isolate);