AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Fix debug-promises tests.

Browse Source 
Using assertEquals on two Promises always passes. Use assertSame instead.

R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/455683002

git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22995 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
yangguo@chromium.org 2014-08-08 11:57:51 +00:00
parent d9d6a60973
commit 0c32d8c5cb
11 changed files with 9 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/mjsunit/es6/debug-promises/reject-caught-all.js
View File

@ -36,7 +36,7 @@ function listener(event, exec_state, event_data, data) {
expected_events--;
assertTrue(expected_events >= 0);
assertEquals("reject", event_data.exception().message);
assertEquals(q, event_data.promise());
assertSame(q, event_data.promise());
assertFalse(event_data.uncaught());
}
} catch (e) {

2
test/mjsunit/es6/debug-promises/reject-uncaught-all.js
View File

@ -31,7 +31,7 @@ function listener(event, exec_state, event_data, data) {
assertTrue(expected_events >= 0);
assertEquals("uncaught reject", event_data.exception().message);
assertTrue(event_data.promise() instanceof Promise);
assertEquals(q, event_data.promise());
assertSame(q, event_data.promise());
assertTrue(event_data.uncaught());
// All of the frames on the stack are from native Javascript.
assertEquals(0, exec_state.frameCount());

2
test/mjsunit/es6/debug-promises/reject-uncaught-late.js
View File

@ -38,7 +38,7 @@ function listener(event, exec_state, event_data, data) {
assertTrue(expected_events >= 0);
assertEquals("uncaught reject p", event_data.exception().message);
assertTrue(event_data.promise() instanceof Promise);
assertEquals(p, event_data.promise());
assertSame(p, event_data.promise());
assertTrue(event_data.uncaught());
// Assert that the debug event is triggered at the throw site.
assertTrue(exec_state.frame(0).sourceLineText().indexOf("// event") > 0);

2
test/mjsunit/es6/debug-promises/reject-uncaught-uncaught.js
View File

@ -31,7 +31,7 @@ function listener(event, exec_state, event_data, data) {
assertTrue(expected_events >= 0);
assertEquals("uncaught reject", event_data.exception().message);
assertTrue(event_data.promise() instanceof Promise);
assertEquals(q, event_data.promise());
assertSame(q, event_data.promise());
assertTrue(event_data.uncaught());
// All of the frames on the stack are from native Javascript.
assertEquals(0, exec_state.frameCount());

1
test/mjsunit/es6/debug-promises/reject-with-invalid-reject.js
View File

@ -42,7 +42,6 @@ function listener(event, exec_state, event_data, data) {
assertEquals("number is not a function", event_data.exception().message);
// All of the frames on the stack are from native Javascript.
assertEquals(0, exec_state.frameCount());
assertEquals(q, event_data.promise());
}
} catch (e) {
%AbortJS(e + "\n" + e.stack);

1
test/mjsunit/es6/debug-promises/reject-with-undefined-reject.js
View File

@ -42,7 +42,6 @@ function listener(event, exec_state, event_data, data) {
assertEquals("caught", event_data.exception().message);
// All of the frames on the stack are from native Javascript.
assertEquals(0, exec_state.frameCount());
assertEquals(q, event_data.promise());
}
} catch (e) {
%AbortJS(e + "\n" + e.stack);

2
test/mjsunit/es6/debug-promises/throw-caught-all.js
View File

@ -35,7 +35,7 @@ function listener(event, exec_state, event_data, data) {
expected_events--;
assertTrue(expected_events >= 0);
assertEquals("caught", event_data.exception().message);
assertEquals(q, event_data.promise());
assertSame(q, event_data.promise());
assertFalse(event_data.uncaught());
}
} catch (e) {

2
test/mjsunit/es6/debug-promises/throw-uncaught-all.js
View File

@ -32,7 +32,7 @@ function listener(event, exec_state, event_data, data) {
assertTrue(expected_events >= 0);
assertEquals("uncaught", event_data.exception().message);
assertTrue(event_data.promise() instanceof Promise);
assertEquals(q, event_data.promise());
assertSame(q, event_data.promise());
assertTrue(event_data.uncaught());
// Assert that the debug event is triggered at the throw site.
assertTrue(exec_state.frame(0).sourceLineText().indexOf("// event") > 0);

2
test/mjsunit/es6/debug-promises/throw-uncaught-uncaught.js
View File

@ -32,7 +32,7 @@ function listener(event, exec_state, event_data, data) {
assertTrue(expected_events >= 0);
assertEquals("uncaught", event_data.exception().message);
assertTrue(event_data.promise() instanceof Promise);
assertEquals(q, event_data.promise());
assertSame(q, event_data.promise());
assertTrue(event_data.uncaught());
// Assert that the debug event is triggered at the throw site.
assertTrue(exec_state.frame(0).sourceLineText().indexOf("// event") > 0);

2
test/mjsunit/es6/debug-promises/throw-with-throw-in-reject.js
View File

@ -53,7 +53,7 @@ function listener(event, exec_state, event_data, data) {
} else {
assertUnreachable();
}
assertEquals(q, event_data.promise());
assertSame(q, event_data.promise());
assertTrue(exec_state.frame(0).sourceLineText().indexOf('// event') > 0);
}
} catch (e) {

2
test/mjsunit/es6/debug-promises/throw-with-undefined-reject.js
View File

@ -53,7 +53,7 @@ function listener(event, exec_state, event_data, data) {
} else {
assertUnreachable();
}
assertEquals(q, event_data.promise());
assertSame(q, event_data.promise());
}
} catch (e) {
%AbortJS(e + "\n" + e.stack);