AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

MIPS: Omit redundant smi checks in write barriers.

Browse Source 
Port r19323 (929c047)

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/160713002

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19343 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
plind44@gmail.com 2014-02-12 18:55:33 +00:00
parent 161b2f689a
commit 0cb13eb552
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/mips/lithium-codegen-mips.cc
View File

@ -3967,12 +3967,18 @@ void LCodeGen::DoStoreNamedField(LStoreNamedField* instr) {
} }
Handle<Map> transition = instr->transition(); Handle<Map> transition = instr->transition();
SmiCheck check_needed =
instr->hydrogen()->value()->IsHeapObject()
? OMIT_SMI_CHECK : INLINE_SMI_CHECK;
if (FLAG_track_heap_object_fields && representation.IsHeapObject()) { if (FLAG_track_heap_object_fields && representation.IsHeapObject()) {
Register value = ToRegister(instr->value()); Register value = ToRegister(instr->value());
if (!instr->hydrogen()->value()->type().IsHeapObject()) { if (!instr->hydrogen()->value()->type().IsHeapObject()) {
__ SmiTst(value, scratch); __ SmiTst(value, scratch);
DeoptimizeIf(eq, instr->environment(), scratch, Operand(zero_reg)); DeoptimizeIf(eq, instr->environment(), scratch, Operand(zero_reg));
// We know that value is a smi now, so we can omit the check below.
check_needed = OMIT_SMI_CHECK;
} }
} else if (representation.IsDouble()) { } else if (representation.IsDouble()) {
ASSERT(transition.is_null()); ASSERT(transition.is_null());
@ -4002,9 +4008,6 @@ void LCodeGen::DoStoreNamedField(LStoreNamedField* instr) {
// Do the store. // Do the store.
Register value = ToRegister(instr->value()); Register value = ToRegister(instr->value());
SmiCheck check_needed =
instr->hydrogen()->value()->IsHeapObject()
? OMIT_SMI_CHECK : INLINE_SMI_CHECK;
if (access.IsInobject()) { if (access.IsInobject()) {
MemOperand operand = FieldMemOperand(object, offset); MemOperand operand = FieldMemOperand(object, offset);
__ Store(value, operand, representation); __ Store(value, operand, representation);