AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[torque] do not generate field offsets for internal classes

Browse Source 
Bug: v8:7793
Change-Id: I503622356746acbeaaeca88ce5bacf7ab9c93ab8
Reviewed-on: https://chromium-review.googlesource.com/c/1491215
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#59890}
This commit is contained in:
Tobias Tebbi 2019-02-27 10:19:19 +01:00 committed by Commit Bot
parent 5c05165d42
commit 0d0c910720
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/torque/implementation-visitor.cc
View File

@ -2654,6 +2654,9 @@ void ImplementationVisitor::GenerateClassDefinitions(std::string& file_name) {
"\n\n";
for (auto i : GlobalContext::GetClasses()) {
ClassType* type = i.second;
if (!type->IsExtern()) continue;
// TODO(danno): Ideally (and we've got several core V8 dev's feedback
// supporting this), Torque should generate the constants for the offsets
// directly and not go through the existing layer of macros, which actually
@ -2662,7 +2665,6 @@ void ImplementationVisitor::GenerateClassDefinitions(std::string& file_name) {
new_contents_stream << "#define ";
new_contents_stream << CapifyStringWithUnderscores(i.first)
<< "_FIELDS(V) \\\n";
ClassType* type = i.second;
std::vector<Field> fields = type->fields();
FieldSectionType section = FieldSectionType::kNoSection;
std::set<FieldSectionType> completed_sections;