AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Added access check to SetNormalizedProperty which is used from runtime DefineOrRedefineDataProperty.

Browse Source 
Review URL: http://codereview.chromium.org/647010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3900 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
ricow@chromium.org 2010-02-18 13:13:21 +00:00
parent e5584e45e2
commit 0d6fe0a44f
2 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/objects.cc
View File

@ -2000,10 +2000,12 @@ Object* JSObject::IgnoreAttributesAndSetLocalProperty(
if (!result->IsLoaded()) { if (!result->IsLoaded()) {
return SetLazyProperty(result, name, value, attributes); return SetLazyProperty(result, name, value, attributes);
} }
PropertyDetails details = PropertyDetails(attributes, NORMAL);
// Check of IsReadOnly removed from here in clone. // Check of IsReadOnly removed from here in clone.
switch (result->type()) { switch (result->type()) {
case NORMAL: case NORMAL:
return SetNormalizedProperty(result, value); return SetNormalizedProperty(name, value, details);
case FIELD: case FIELD:
return FastPropertyAtPut(result->GetFieldIndex(), value); return FastPropertyAtPut(result->GetFieldIndex(), value);
case MAP_TRANSITION: case MAP_TRANSITION:

10
src/runtime.cc
View File

@ -2926,12 +2926,14 @@ static Object* Runtime_DefineOrRedefineDataProperty(Arguments args) {
// correctly in the case where a property is a field and is reset with // correctly in the case where a property is a field and is reset with
// new attributes. // new attributes.
if (result.IsProperty() && attr != result.GetAttributes()) { if (result.IsProperty() && attr != result.GetAttributes()) {
PropertyDetails details = PropertyDetails(attr, NORMAL);
// New attributes - normalize to avoid writing to instance descriptor // New attributes - normalize to avoid writing to instance descriptor
js_object->NormalizeProperties(KEEP_INOBJECT_PROPERTIES, 0); js_object->NormalizeProperties(CLEAR_INOBJECT_PROPERTIES, 0);
return js_object->SetNormalizedProperty(*name, *obj_value, details); // Use IgnoreAttributes version since a readonly property may be
// overridden and SetProperty does not allow this.
return js_object->IgnoreAttributesAndSetLocalProperty(*name,
*obj_value,
attr);
} }
return Runtime::SetObjectProperty(js_object, name, obj_value, attr); return Runtime::SetObjectProperty(js_object, name, obj_value, attr);
} }