AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[iwyu] Fix jsregexp.h

Browse Source 
R=jgruber@chromium.org

Bug: v8:7965
Change-Id: Icad6d0f2e43d8c5bb62ad160a186b1d3dbd57781
Reviewed-on: https://chromium-review.googlesource.com/c/1303298
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#57079}
This commit is contained in:
Clemens Hammacher 2018-10-27 17:55:34 +02:00 committed by Commit Bot
parent 4b94fab9af
commit 0d9ed95041
3 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/regexp/jsregexp-inl.h
View File

@ -75,6 +75,10 @@ int32_t* RegExpImpl::GlobalCache::LastSuccessfulMatch() {
return &register_array_[index];
}
RegExpEngine::CompilationResult::CompilationResult(Isolate* isolate,
const char* error_message)
: error_message(error_message),
code(ReadOnlyRoots(isolate).the_hole_value()) {}
} // namespace internal
} // namespace v8

13
src/regexp/jsregexp.h
View File

@ -1504,15 +1504,12 @@ struct RegExpCompileData {
class RegExpEngine: public AllStatic {
public:
struct CompilationResult {
CompilationResult(Isolate* isolate, const char* error_message)
: error_message(error_message),
code(ReadOnlyRoots(isolate).the_hole_value()),
num_registers(0) {}
inline CompilationResult(Isolate* isolate, const char* error_message);
CompilationResult(Object* code, int registers)
: error_message(nullptr), code(code), num_registers(registers) {}
const char* error_message;
Object* code;
int num_registers;
: code(code), num_registers(registers) {}
const char* const error_message = nullptr;
Object* const code;
int const num_registers = 0;
};
static CompilationResult Compile(Isolate* isolate, Zone* zone,

1
tools/generate-header-include-checks.py
View File

@ -29,7 +29,6 @@ AUTO_EXCLUDE = [
# flag-definitions.h needs a mode set for being included.
'src/flag-definitions.h',
# blacklist of headers we need to fix (https://crbug.com/v8/7965).
'src/regexp/jsregexp.h',
'src/transitions.h',
]
AUTO_EXCLUDE_PATTERNS = [