AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Put experimental extras through the same filters as non-experimental

Browse Source 
When introducing experimental extras I forgot to update this check. That resulted in experimental extras running through the steps normally reserved for non-extra natives: macro and constant expansion, validation, and minification. This causes problems since per the linked bug minification is buggy.

R=yangguo@chromium.org, jochen@chromium.org
BUG=v8:4064
LOG=N

Review URL: https://codereview.chromium.org/1400253002

Cr-Commit-Position: refs/heads/master@{#31270}
This commit is contained in:
domenic 2015-10-14 10:38:27 -07:00 committed by Commit bot
parent ab3110e875
commit 0db3710421
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/js2c.py
View File

@ -417,7 +417,7 @@ def PrepareSources(source_files, native_type, emit_js):
message_template_file = message_template_files[0]
filters = None
if native_type == "EXTRAS":
if native_type in ("EXTRAS", "EXPERIMENTAL_EXTRAS"):
filters = BuildExtraFilterChain()
else:
filters = BuildFilterChain(macro_file, message_template_file)