AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Do not flatten the string, but just write it out.

Browse Source 
In DOM bindings in many cases the string would be externalized immediately.  For other cases
I am going to add explicit flattening.  Overall, it looks like if user wants to flat string
before writing, it should be an explicit method invocation (going to add TryFlattenIfNotFlat
into public V8 API).

Review URL: http://codereview.chromium.org/255004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@2999 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
This commit is contained in:
antonm@chromium.org 2009-09-30 14:25:21 +00:00
parent 2c2554ec3c
commit 0db55a9456
1 changed files with 4 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/api.cc
View File

@ -2447,20 +2447,14 @@ int String::Write(uint16_t* buffer, int start, int length) const {
ENTER_V8; ENTER_V8;
ASSERT(start >= 0 && length >= -1); ASSERT(start >= 0 && length >= -1);
i::Handle<i::String> str = Utils::OpenHandle(this); i::Handle<i::String> str = Utils::OpenHandle(this);
// Flatten the string for efficiency. This applies whether we are
// using StringInputBuffer or Get(i) to access the characters.
str->TryFlattenIfNotFlat();
int end = length; int end = length;
if ( (length == -1) || (length > str->length() - start) ) if ( (length == -1) || (length > str->length() - start) )
end = str->length() - start; end = str->length() - start;
if (end < 0) return 0; if (end < 0) return 0;
write_input_buffer.Reset(start, *str); i::String::WriteToFlat(*str, buffer, start, end);
int i; if (length == -1 || end < length)
for (i = 0; i < end; i++) buffer[end] = '\0';
buffer[i] = write_input_buffer.GetNext(); return end;
if (length == -1 || i < length)
buffer[i] = '\0';
return i;
} }