AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

PPC/s390: Various post-Code rename cleanups

Browse Source 
Port c0367102a3

Original Commit Message:

    The biggest chunk of this CL is related to the CodeBuilder now
    returning a Code object instead of an InstructionStream. Most
    codegen-related parts of the codebase had to be updated, including
    compiler.cc, pipeline.cc, and many tests. The good news is,
    we now have 400 fewer references to InstructionStream.

    Smaller changes:
    - Remove ToAbstractCode
    - Remove dead code
    - Update comments
    - Update method and variable names

R=jgruber@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com
BUG=
LOG=N

Change-Id: Ib81459f65b474acb2f4f4e9bc547139e54877615
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4177048
Commit-Queue: Milad Farazmand <mfarazma@redhat.com>
Reviewed-by: Junliang Yan <junyan@redhat.com>
Cr-Commit-Position: refs/heads/main@{#85378}
This commit is contained in:
Milad Fa 2023-01-18 13:44:54 -05:00 committed by V8 LUCI CQ
parent 360337cd80
commit 0dbff5d07b
4 changed files with 46 additions and 44 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/regexp/ppc/regexp-macro-assembler-ppc.cc
View File

@ -1057,13 +1057,14 @@ Handle<HeapObject> RegExpMacroAssemblerPPC::GetCode(Handle<String> source) {
CodeDesc code_desc;
masm_->GetCode(isolate(), &code_desc);
Handle<InstructionStream> code =
Handle<Code> code =
Factory::CodeBuilder(isolate(), code_desc, CodeKind::REGEXP)
.set_self_reference(masm_->CodeObject())
.Build();
Handle<InstructionStream> istream(code->instruction_stream(), isolate());
PROFILE(masm_->isolate(),
RegExpCodeCreateEvent(Handle<AbstractCode>::cast(code), source));
return Handle<HeapObject>::cast(code);
RegExpCodeCreateEvent(Handle<AbstractCode>::cast(istream), source));
return Handle<HeapObject>::cast(istream);
}

7
src/regexp/s390/regexp-macro-assembler-s390.cc
View File

@ -1062,13 +1062,14 @@ Handle<HeapObject> RegExpMacroAssemblerS390::GetCode(Handle<String> source) {
CodeDesc code_desc;
masm_->GetCode(isolate(), &code_desc);
Handle<InstructionStream> code =
Handle<Code> code =
Factory::CodeBuilder(isolate(), code_desc, CodeKind::REGEXP)
.set_self_reference(masm_->CodeObject())
.Build();
Handle<InstructionStream> istream(code->instruction_stream(), isolate());
PROFILE(masm_->isolate(),
RegExpCodeCreateEvent(Handle<AbstractCode>::cast(code), source));
return Handle<HeapObject>::cast(code);
RegExpCodeCreateEvent(Handle<AbstractCode>::cast(istream), source));
return Handle<HeapObject>::cast(istream);
}
void RegExpMacroAssemblerS390::GoTo(Label* to) { BranchOrBacktrack(al, to); }

26
test/cctest/test-assembler-ppc.cc
View File

@ -60,7 +60,7 @@ TEST(0) {
CodeDesc desc;
assm.GetCode(isolate, &desc);
Handle<InstructionStream> code =
Handle<Code> code =
Factory::CodeBuilder(isolate, desc, CodeKind::FOR_TESTING).Build();
#ifdef DEBUG
code->Print();
@ -96,7 +96,7 @@ TEST(1) {
CodeDesc desc;
assm.GetCode(isolate, &desc);
Handle<InstructionStream> code =
Handle<Code> code =
Factory::CodeBuilder(isolate, desc, CodeKind::FOR_TESTING).Build();
#ifdef DEBUG
code->Print();
@ -144,7 +144,7 @@ TEST(2) {
CodeDesc desc;
assm.GetCode(isolate, &desc);
Handle<InstructionStream> code =
Handle<Code> code =
Factory::CodeBuilder(isolate, desc, CodeKind::FOR_TESTING).Build();
#ifdef DEBUG
code->Print();
@ -213,7 +213,7 @@ TEST(3) {
CodeDesc desc;
assm.GetCode(isolate, &desc);
Handle<InstructionStream> code =
Handle<Code> code =
Factory::CodeBuilder(isolate, desc, CodeKind::FOR_TESTING).Build();
#ifdef DEBUG
code->Print();
@ -328,7 +328,7 @@ TEST(4) {
Object code = isolate->heap()->CreateCode(
desc,
CodeKind::FOR_TESTING,
Handle<InstructionStream>())->ToObjectChecked();
Handle<Code>())->ToObjectChecked();
CHECK(code->IsCode());
#ifdef DEBUG
Code::cast(code)->Print();
@ -388,7 +388,7 @@ TEST(5) {
Object code = isolate->heap()->CreateCode(
desc,
CodeKind::FOR_TESTING,
Handle<InstructionStream>())->ToObjectChecked();
Handle<Code>())->ToObjectChecked();
CHECK(code->IsCode());
#ifdef DEBUG
Code::cast(code)->Print();
@ -423,7 +423,7 @@ TEST(6) {
Object code = isolate->heap()->CreateCode(
desc,
CodeKind::FOR_TESTING,
Handle<InstructionStream>())->ToObjectChecked();
Handle<Code>())->ToObjectChecked();
CHECK(code->IsCode());
#ifdef DEBUG
Code::cast(code)->Print();
@ -498,7 +498,7 @@ static void TestRoundingMode(VCVTTypes types,
Object code = isolate->heap()->CreateCode(
desc,
CodeKind::FOR_TESTING,
Handle<InstructionStream>())->ToObjectChecked();
Handle<Code>())->ToObjectChecked();
CHECK(code->IsCode());
#ifdef DEBUG
Code::cast(code)->Print();
@ -685,7 +685,7 @@ TEST(8) {
Object code = isolate->heap()->CreateCode(
desc,
CodeKind::FOR_TESTING,
Handle<InstructionStream>())->ToObjectChecked();
Handle<Code>())->ToObjectChecked();
CHECK(code->IsCode());
#ifdef DEBUG
Code::cast(code)->Print();
@ -800,7 +800,7 @@ TEST(9) {
Object code = isolate->heap()->CreateCode(
desc,
CodeKind::FOR_TESTING,
Handle<InstructionStream>())->ToObjectChecked();
Handle<Code>())->ToObjectChecked();
CHECK(code->IsCode());
#ifdef DEBUG
Code::cast(code)->Print();
@ -911,7 +911,7 @@ TEST(10) {
Object code = isolate->heap()->CreateCode(
desc,
CodeKind::FOR_TESTING,
Handle<InstructionStream>())->ToObjectChecked();
Handle<Code>())->ToObjectChecked();
CHECK(code->IsCode());
#ifdef DEBUG
Code::cast(code)->Print();
@ -1008,7 +1008,7 @@ TEST(11) {
Object code = isolate->heap()->CreateCode(
desc,
CodeKind::FOR_TESTING,
Handle<InstructionStream>())->ToObjectChecked();
Handle<Code>())->ToObjectChecked();
CHECK(code->IsCode());
#ifdef DEBUG
Code::cast(code)->Print();
@ -1072,7 +1072,7 @@ TEST(WordSizedVectorInstructions) {
CodeDesc desc;
assm.GetCode(isolate, &desc);
Handle<InstructionStream> code =
Handle<Code> code =
Factory::CodeBuilder(isolate, desc, CodeKind::FOR_TESTING).Build();
#ifdef DEBUG
code->Print();

50
test/cctest/test-assembler-s390.cc
View File

@ -63,7 +63,7 @@ TEST(0) {
CodeDesc desc;
assm.GetCode(isolate, &desc);
Handle<InstructionStream> code =
Handle<Code> code =
Factory::CodeBuilder(isolate, desc, CodeKind::FOR_TESTING).Build();
#ifdef DEBUG
code->Print();
@ -102,7 +102,7 @@ TEST(1) {
CodeDesc desc;
assm.GetCode(isolate, &desc);
Handle<InstructionStream> code =
Handle<Code> code =
Factory::CodeBuilder(isolate, desc, CodeKind::FOR_TESTING).Build();
#ifdef DEBUG
code->Print();
@ -153,7 +153,7 @@ TEST(2) {
CodeDesc desc;
assm.GetCode(isolate, &desc);
Handle<InstructionStream> code =
Handle<Code> code =
Factory::CodeBuilder(isolate, desc, CodeKind::FOR_TESTING).Build();
#ifdef DEBUG
code->Print();
@ -208,7 +208,7 @@ TEST(3) {
CodeDesc desc;
assm.GetCode(isolate, &desc);
Handle<InstructionStream> code =
Handle<Code> code =
Factory::CodeBuilder(isolate, desc, CodeKind::FOR_TESTING).Build();
#ifdef DEBUG
code->Print();
@ -249,8 +249,8 @@ TEST(4) {
CodeDesc desc;
assm.GetCode(isolate, &desc);
Handle<InstructionStream> code = isolate->factory()->NewCode(
desc, CodeKind::FOR_TESTING, Handle<InstructionStream>());
Handle<Code> code = isolate->factory()->NewCode(
desc, CodeKind::FOR_TESTING, Handle<Code>());
#ifdef DEBUG
code->Print();
#endif
@ -277,8 +277,8 @@ TEST(5) {
CodeDesc desc;
assm.GetCode(isolate, &desc);
Handle<InstructionStream> code = isolate->factory()->NewCode(
desc, CodeKind::FOR_TESTING, Handle<InstructionStream>());
Handle<Code> code = isolate->factory()->NewCode(
desc, CodeKind::FOR_TESTING, Handle<Code>());
#ifdef DEBUG
code->Print();
#endif
@ -311,8 +311,8 @@ TEST(6) {
CodeDesc desc;
assm.GetCode(isolate, &desc);
Handle<InstructionStream> code = isolate->factory()->NewCode(
desc, CodeKind::FOR_TESTING, Handle<InstructionStream>());
Handle<Code> code = isolate->factory()->NewCode(
desc, CodeKind::FOR_TESTING, Handle<Code>());
#ifdef DEBUG
code->Print();
#endif
@ -343,8 +343,8 @@ TEST(7) {
CodeDesc desc;
assm.GetCode(isolate, &desc);
Handle<InstructionStream> code = isolate->factory()->NewCode(
desc, CodeKind::FOR_TESTING, Handle<InstructionStream>());
Handle<Code> code = isolate->factory()->NewCode(
desc, CodeKind::FOR_TESTING, Handle<Code>());
#ifdef DEBUG
code->Print();
#endif
@ -374,8 +374,8 @@ TEST(8) {
CodeDesc desc;
assm.GetCode(isolate, &desc);
Handle<InstructionStream> code = isolate->factory()->NewCode(
desc, CodeKind::FOR_TESTING, Handle<InstructionStream>());
Handle<Code> code = isolate->factory()->NewCode(
desc, CodeKind::FOR_TESTING, Handle<Code>());
#ifdef DEBUG
code->Print();
#endif
@ -401,8 +401,8 @@ TEST(9) {
CodeDesc desc;
assm.GetCode(isolate, &desc);
Handle<InstructionStream> code = isolate->factory()->NewCode(
desc, CodeKind::FOR_TESTING, Handle<InstructionStream>());
Handle<Code> code = isolate->factory()->NewCode(
desc, CodeKind::FOR_TESTING, Handle<Code>());
#ifdef DEBUG
code->Print();
#endif
@ -486,7 +486,7 @@ TEST(10) {
CodeDesc desc;
assm.GetCode(isolate, &desc);
Handle<InstructionStream> code =
Handle<Code> code =
Factory::CodeBuilder(isolate, desc, CodeKind::FOR_TESTING).Build();
#ifdef DEBUG
code->Print();
@ -540,7 +540,7 @@ TEST(11) {
CodeDesc desc;
assm.GetCode(isolate, &desc);
Handle<InstructionStream> code =
Handle<Code> code =
Factory::CodeBuilder(isolate, desc, CodeKind::FOR_TESTING).Build();
#ifdef DEBUG
code->Print();
@ -594,7 +594,7 @@ TEST(12) {
CodeDesc desc;
assm.GetCode(isolate, &desc);
Handle<InstructionStream> code =
Handle<Code> code =
Factory::CodeBuilder(isolate, desc, CodeKind::FOR_TESTING).Build();
#ifdef DEBUG
code->Print();
@ -658,7 +658,7 @@ TEST(13) {
CodeDesc desc;
assm.GetCode(isolate, &desc);
Handle<InstructionStream> code =
Handle<Code> code =
Factory::CodeBuilder(isolate, desc, CodeKind::FOR_TESTING).Build();
#ifdef DEBUG
code->Print();
@ -749,7 +749,7 @@ TEST(14) {
CodeDesc desc;
assm.GetCode(isolate, &desc);
Handle<InstructionStream> code =
Handle<Code> code =
Factory::CodeBuilder(isolate, desc, CodeKind::FOR_TESTING).Build();
#ifdef DEBUG
code->Print();
@ -839,7 +839,7 @@ TEST(15) {
CodeDesc desc;
assm.GetCode(isolate, &desc);
Handle<InstructionStream> code =
Handle<Code> code =
Factory::CodeBuilder(isolate, desc, CodeKind::FOR_TESTING).Build();
#ifdef DEBUG
code->Print();
@ -886,7 +886,7 @@ TEST(16) {
CodeDesc desc;
assm.GetCode(isolate, &desc);
Handle<InstructionStream> code =
Handle<Code> code =
Factory::CodeBuilder(isolate, desc, CodeKind::FOR_TESTING).Build();
#ifdef DEBUG
code->Print();
@ -960,7 +960,7 @@ TEST(17) {
CodeDesc desc;
assm.GetCode(isolate, &desc);
Handle<InstructionStream> code =
Handle<Code> code =
Factory::CodeBuilder(isolate, desc, CodeKind::FOR_TESTING).Build();
#ifdef DEBUG
code->Print();
@ -1052,7 +1052,7 @@ TEST(18) {
CodeDesc desc;
assm.GetCode(isolate, &desc);
Handle<InstructionStream> code =
Handle<Code> code =
Factory::CodeBuilder(isolate, desc, CodeKind::FOR_TESTING).Build();
#ifdef DEBUG
code->Print();