From 0ec3ba8fe4f20ea86866ed7f3b0a4eb028d5b5aa Mon Sep 17 00:00:00 2001 From: "vitalyr@chromium.org" Date: Wed, 9 Nov 2011 19:02:41 +0000 Subject: [PATCH] Tighten handling of pthread_create errors on Linux. The return value of pthread_create is now checked to be 0. Tests on MIPS boards had some silent and hard to find timeouts and errors related to this. This ensures a proper error message and shutdown if a thread could not be started. BUG= TEST= Review URL: http://codereview.chromium.org/8497041 Patch from Gergely Kis . git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@9945 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/platform-linux.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/platform-linux.cc b/src/platform-linux.cc index 4271a70d25..e72d095b0a 100644 --- a/src/platform-linux.cc +++ b/src/platform-linux.cc @@ -768,7 +768,8 @@ void Thread::Start() { pthread_attr_setstacksize(&attr, static_cast(stack_size_)); attr_ptr = &attr; } - pthread_create(&data_->thread_, attr_ptr, ThreadEntry, this); + int result = pthread_create(&data_->thread_, attr_ptr, ThreadEntry, this); + CHECK_EQ(0, result); ASSERT(data_->thread_ != kNoThread); }