AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[wasm] Gate SIMD load/store opcodes with the --wasm-simd-prototype flag.

Browse Source 
BUG=chromium:702460

R=mtrofin@chromium.org, bbudge@chromium.org

Review-Url: https://codereview.chromium.org/2794693002
Cr-Commit-Position: refs/heads/master@{#44319}
This commit is contained in:
gdeepti 2017-03-31 15:52:59 -07:00 committed by Commit bot
parent 9e28cf1318
commit 0f9680cd2d
3 changed files with 50 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/wasm/function-body-decoder.cc
View File

@ -1158,6 +1158,7 @@ class WasmFullDecoder : public WasmDecoder {
len = DecodeLoadMem(kWasmF64, MachineType::Float64()); len = DecodeLoadMem(kWasmF64, MachineType::Float64());
break; break;
case kExprS128LoadMem: case kExprS128LoadMem:
CHECK_PROTOTYPE_OPCODE(wasm_simd_prototype);
len = DecodeLoadMem(kWasmS128, MachineType::Simd128()); len = DecodeLoadMem(kWasmS128, MachineType::Simd128());
break; break;
case kExprI32StoreMem8: case kExprI32StoreMem8:
@ -1188,6 +1189,7 @@ class WasmFullDecoder : public WasmDecoder {
len = DecodeStoreMem(kWasmF64, MachineType::Float64()); len = DecodeStoreMem(kWasmF64, MachineType::Float64());
break; break;
case kExprS128StoreMem: case kExprS128StoreMem:
CHECK_PROTOTYPE_OPCODE(wasm_simd_prototype);
len = DecodeStoreMem(kWasmS128, MachineType::Simd128()); len = DecodeStoreMem(kWasmS128, MachineType::Simd128());
break; break;
case kExprGrowMemory: { case kExprGrowMemory: {

47
test/mjsunit/regress/wasm/regression-702460.js Normal file
View File

@ -0,0 +1,47 @@
// Copyright 2017 the V8 project authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
load("test/mjsunit/wasm/wasm-constants.js");
load("test/mjsunit/wasm/wasm-module-builder.js");
(function() {
"use asm";
var builder = new WasmModuleBuilder();
builder.addFunction("regression_702460", kSig_i_v)
.addBody([
kExprI32Const, 0x52,
kExprI32Const, 0x41,
kExprI32Const, 0x3c,
kExprI32Const, 0xdc, 0x01,
kExprGrowMemory, 0x00,
kExprGrowMemory, 0x00,
kExprGrowMemory, 0x00,
kExprSetLocal, 0x00,
kExprGrowMemory, 0x00,
kExprGrowMemory, 0x00,
kExprGrowMemory, 0x00,
kExprGrowMemory, 0x00,
kExprGrowMemory, 0x00,
kExprGrowMemory, 0x00,
kExprGrowMemory, 0x00,
kExprGrowMemory, 0x00,
kExprGrowMemory, 0x00,
kExprGrowMemory, 0x00,
kExprGrowMemory, 0x00,
kExprGrowMemory, 0x00,
kExprGrowMemory, 0x00,
kExprGrowMemory, 0x00,
kExprGrowMemory, 0x00,
kExprGrowMemory, 0x00,
kExprGrowMemory, 0x00,
kExprGrowMemory, 0x00,
kExprGrowMemory, 0x00,
kExprGrowMemory, 0x00,
kExprGrowMemory, 0x00,
kExprS128LoadMem, 0x00, 0x40,
kExprUnreachable,
kExprGrowMemory, 0x00
]).exportFunc();
assertThrows(() => builder.instantiate());
})();

1
test/mjsunit/wasm/wasm-constants.js
View File

@ -315,6 +315,7 @@ let kExprI32ReinterpretF32 = 0xbc;
let kExprI64ReinterpretF64 = 0xbd; let kExprI64ReinterpretF64 = 0xbd;
let kExprF32ReinterpretI32 = 0xbe; let kExprF32ReinterpretI32 = 0xbe;
let kExprF64ReinterpretI64 = 0xbf; let kExprF64ReinterpretI64 = 0xbf;
let kExprS128LoadMem = 0xc0;
let kTrapUnreachable = 0; let kTrapUnreachable = 0;
let kTrapMemOutOfBounds = 1; let kTrapMemOutOfBounds = 1;