AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[Interpreter] No need to read/return a value in GeneratorClose.

Browse Source 
An oversight in Friday's CL. Thx to neis@chromium.org for the tip!

BUG=v8:6351
TBR=rmcilroy@chromium.org

Review-Url: https://codereview.chromium.org/2893223002
Cr-Commit-Position: refs/heads/master@{#45444}
This commit is contained in:
mvstanton 2017-05-22 01:23:16 -07:00 committed by Commit bot
parent 62b0de1ef5
commit 0fb167d45d
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/interpreter/interpreter-intrinsics-generator.cc
View File

@ -437,13 +437,10 @@ Node* IntrinsicsGenerator::GeneratorGetResumeMode(Node* args_reg,
Node* IntrinsicsGenerator::GeneratorClose(Node* args_reg, Node* arg_count, Node* IntrinsicsGenerator::GeneratorClose(Node* args_reg, Node* arg_count,
Node* context) { Node* context) {
Node* generator = __ LoadRegister(args_reg); Node* generator = __ LoadRegister(args_reg);
Node* const value =
__ LoadObjectField(generator, JSGeneratorObject::kResumeModeOffset);
__ StoreObjectFieldNoWriteBarrier( __ StoreObjectFieldNoWriteBarrier(
generator, JSGeneratorObject::kContinuationOffset, generator, JSGeneratorObject::kContinuationOffset,
__ SmiConstant(JSGeneratorObject::kGeneratorClosed)); __ SmiConstant(JSGeneratorObject::kGeneratorClosed));
return __ UndefinedConstant();
return value;
} }
Node* IntrinsicsGenerator::AsyncGeneratorReject(Node* input, Node* arg_count, Node* IntrinsicsGenerator::AsyncGeneratorReject(Node* input, Node* arg_count,