From 0fb929af252b0751f4f7966fe34ce4c64d37f169 Mon Sep 17 00:00:00 2001 From: Georg Neis Date: Wed, 30 Oct 2019 12:00:57 +0100 Subject: [PATCH] [turbofan] Don't unconditionally read heap when printing types ... since we may be in the background. Print the HeapObjectRef instead, which will read the heap when it's allowed to do so. Bug: v8:9541 Change-Id: I201c6dcd83e1b050393d633e4d59aec636772da6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1889876 Auto-Submit: Georg Neis Reviewed-by: Nico Hartmann Commit-Queue: Georg Neis Cr-Commit-Position: refs/heads/master@{#64655} --- src/compiler/types.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compiler/types.cc b/src/compiler/types.cc index caa086bbd3..7c2a254a31 100644 --- a/src/compiler/types.cc +++ b/src/compiler/types.cc @@ -1022,7 +1022,7 @@ void Type::PrintTo(std::ostream& os) const { if (this->IsBitset()) { BitsetType::Print(os, this->AsBitset()); } else if (this->IsHeapConstant()) { - os << "HeapConstant(" << Brief(*this->AsHeapConstant()->Value()) << ")"; + os << "HeapConstant(" << this->AsHeapConstant()->Ref() << ")"; } else if (this->IsOtherNumberConstant()) { os << "OtherNumberConstant(" << this->AsOtherNumberConstant()->Value() << ")";