AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

CpuProfiler: slightly reduce the size of JumpTable code on arm64.

Browse Source 
BUG=chromium:452067
LOG=n
R=svenpanne@chromium.org, jacob.bramley@arm.com, yurys@chromium.org

Review URL: https://codereview.chromium.org/995813002

Cr-Commit-Position: refs/heads/master@{#27112}
This commit is contained in:
loislo 2015-03-10 08:12:53 -07:00 committed by Commit bot
parent c1d0f845a9
commit 0fcebccd7e
1 changed files with 13 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
src/arm64/lithium-codegen-arm64.cc
View File

@ -842,7 +842,7 @@ bool LCodeGen::GenerateDeferredCode() {
bool LCodeGen::GenerateJumpTable() { bool LCodeGen::GenerateJumpTable() {
Label needs_frame, restore_caller_doubles, call_deopt_entry; Label needs_frame, call_deopt_entry;
if (jump_table_.length() > 0) { if (jump_table_.length() > 0) {
Comment(";;; -------------------- Jump table --------------------"); Comment(";;; -------------------- Jump table --------------------");
@ -866,22 +866,18 @@ bool LCodeGen::GenerateJumpTable() {
if (table_entry->needs_frame) { if (table_entry->needs_frame) {
DCHECK(!info()->saves_caller_doubles()); DCHECK(!info()->saves_caller_doubles());
Comment(";;; call deopt with frame");
// Save lr before Bl, fp will be adjusted in the needs_frame code. // Save lr before Bl, fp will be adjusted in the needs_frame code.
__ Push(lr, fp, cp); __ Push(lr, fp);
// Reuse the existing needs_frame code. // Reuse the existing needs_frame code.
__ Bl(&needs_frame); __ Bl(&needs_frame);
} else if (info()->saves_caller_doubles()) {
DCHECK(info()->IsStub());
// Reuse the existing restore_caller_doubles code.
__ Bl(&restore_caller_doubles);
} else { } else {
// There is nothing special to do, so just continue to the second-level // There is nothing special to do, so just continue to the second-level
// table. // table.
__ Bl(&call_deopt_entry); __ Bl(&call_deopt_entry);
} }
bool last_entry = (i + 1) == length; masm()->CheckConstPool(false, false);
masm()->CheckConstPool(false, last_entry);
} }
if (needs_frame.is_linked()) { if (needs_frame.is_linked()) {
@ -890,25 +886,24 @@ bool LCodeGen::GenerateJumpTable() {
// building, install a special marker there instead. // building, install a special marker there instead.
DCHECK(info()->IsStub()); DCHECK(info()->IsStub());
Comment(";;; needs_frame common code");
UseScratchRegisterScope temps(masm()); UseScratchRegisterScope temps(masm());
Register stub_marker = temps.AcquireX(); Register stub_marker = temps.AcquireX();
__ Bind(&needs_frame); __ Bind(&needs_frame);
__ Mov(stub_marker, Smi::FromInt(StackFrame::STUB)); __ Mov(stub_marker, Smi::FromInt(StackFrame::STUB));
__ Push(stub_marker); __ Push(cp, stub_marker);
__ Add(fp, __ StackPointer(), 2 * kPointerSize); __ Add(fp, __ StackPointer(), 2 * kPointerSize);
if (restore_caller_doubles.is_linked()) {
__ B(&call_deopt_entry);
}
}
if (restore_caller_doubles.is_linked()) {
__ Bind(&restore_caller_doubles);
RestoreCallerDoubles();
} }
// Generate common code for calling the second-level deopt table. // Generate common code for calling the second-level deopt table.
Register deopt_entry = temps.AcquireX();
__ Bind(&call_deopt_entry); __ Bind(&call_deopt_entry);
if (info()->saves_caller_doubles()) {
DCHECK(info()->IsStub());
RestoreCallerDoubles();
}
Register deopt_entry = temps.AcquireX();
__ Mov(deopt_entry, Operand(reinterpret_cast<uint64_t>(base), __ Mov(deopt_entry, Operand(reinterpret_cast<uint64_t>(base),
RelocInfo::RUNTIME_ENTRY)); RelocInfo::RUNTIME_ENTRY));
__ Add(deopt_entry, deopt_entry, entry_offset); __ Add(deopt_entry, deopt_entry, entry_offset);