AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[cleanup] Fix use of deprecated Concat in d8

Browse Source 
Use the Isolate* version of Concat.

Bug: v8:7754
Change-Id: I3d16405032ab0690c57e2ba615cac60d8fa92464
Reviewed-on: https://chromium-review.googlesource.com/1146578
Reviewed-by: Mythri Alle <mythria@chromium.org>
Commit-Queue: Dan Elphick <delphick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54608}
This commit is contained in:
Dan Elphick 2018-07-23 10:48:17 +01:00 committed by Commit Bot
parent 7e5905fd9c
commit 108bef1603
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/d8-posix.cc
View File

@ -342,7 +342,7 @@ static Local<Value> GetStdout(Isolate* isolate, int child_fd,
Local<String> addition =
String::NewFromUtf8(isolate, buffer, NewStringType::kNormal, length)
.ToLocalChecked();
accumulator = String::Concat(accumulator, addition);
accumulator = String::Concat(isolate, accumulator, addition);
fullness = bytes_read + fullness - length;
memcpy(buffer, buffer + length, fullness);
}