AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[parser] report errors for invalid binding patterns in async formal parameters

Browse Source 
BUG=v8:4483, v8:5190

R=caitp@igalia.com, nikolaos@chromium.org

Review-Url: https://codereview.chromium.org/2139063002
Cr-Commit-Position: refs/heads/master@{#37691}
This commit is contained in:
littledan 2016-07-12 12:47:43 -07:00 committed by Commit bot
parent ce5265016b
commit 117fda1401
2 changed files with 31 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

32
src/parsing/parser-base.h
View File

@ -2827,16 +2827,30 @@ ParserBase<Traits>::ParseLeftHandSideExpression(
}
}
Scanner::Location spread_pos;
typename Traits::Type::ExpressionList args =
ParseArguments(&spread_pos, is_async, classifier, CHECK_OK);
if (V8_UNLIKELY(is_async && peek() == Token::ARROW)) {
if (args->length()) {
// async ( Arguments ) => ...
return Traits::ExpressionListToExpression(args);
typename Traits::Type::ExpressionList args;
if (V8_UNLIKELY(is_async)) {
ExpressionClassifier async_classifier(this);
args = ParseArguments(&spread_pos, true, &async_classifier, CHECK_OK);
if (peek() == Token::ARROW) {
ValidateBindingPattern(&async_classifier, CHECK_OK);
if (!async_classifier.is_valid_async_arrow_formal_parameters()) {
ReportClassifierError(
async_classifier.async_arrow_formal_parameters_error());
*ok = false;
return this->EmptyExpression();
}
if (args->length()) {
// async ( Arguments ) => ...
return Traits::ExpressionListToExpression(args);
}
// async () => ...
return factory()->NewEmptyParentheses(pos);
} else {
classifier->Accumulate(&async_classifier,
ExpressionClassifier::AllProductions);
}
// async () => ...
return factory()->NewEmptyParentheses(pos);
} else {
args = ParseArguments(&spread_pos, false, classifier, CHECK_OK);
}
ArrowFormalParametersUnexpectedToken(classifier);

8
test/cctest/test-parsing.cc
View File

@ -7726,6 +7726,14 @@ TEST(AsyncAwaitErrors) {
"var f = async(await) => 1;",
"var f = async(await = 1) => 1;",
"var f = async(...[await]) => 1;",
// v8:5190
"var f = async(1) => 1",
"var f = async('str') => 1",
"var f = async(/foo/) => 1",
"var f = async({ foo = async(1) => 1 }) => 1",
"var f = async({ foo = async(a) => 1 })",
NULL
};
// clang-format on