From 11fd577261f47d9844eabf0ad18182d54f1a78ab Mon Sep 17 00:00:00 2001 From: "jkummerow@chromium.org" Date: Mon, 26 Aug 2013 13:04:05 +0000 Subject: [PATCH] Lower kInitialMaxFastElementArray constant to 95K to work around erroneous "illegal access" error on x64. BUG=v8:2790 R=hpayer@chromium.org Review URL: https://codereview.chromium.org/22877039 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@16324 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/objects.h | 6 +++++- test/mjsunit/regress/regress-2790.js | 31 ++++++++++++++++++++++++++++ 2 files changed, 36 insertions(+), 1 deletion(-) create mode 100644 test/mjsunit/regress/regress-2790.js diff --git a/src/objects.h b/src/objects.h index 7d9329afe0..91c3d336f3 100644 --- a/src/objects.h +++ b/src/objects.h @@ -2716,7 +2716,11 @@ class JSObject: public JSReceiver { // don't want to be wasteful with long lived objects. static const int kMaxUncheckedOldFastElementsLength = 500; - static const int kInitialMaxFastElementArray = 100000; + // TODO(2790): HAllocate currently always allocates fast backing stores + // in new space, where on x64 we can only fit ~98K elements. Keep this + // limit lower than that until HAllocate is made smarter. + static const int kInitialMaxFastElementArray = 95000; + static const int kFastPropertiesSoftLimit = 12; static const int kMaxFastProperties = 64; static const int kMaxInstanceSize = 255 * kPointerSize; diff --git a/test/mjsunit/regress/regress-2790.js b/test/mjsunit/regress/regress-2790.js new file mode 100644 index 0000000000..86305b8867 --- /dev/null +++ b/test/mjsunit/regress/regress-2790.js @@ -0,0 +1,31 @@ +// Copyright 2013 the V8 project authors. All rights reserved. +// Redistribution and use in source and binary forms, with or without +// modification, are permitted provided that the following conditions are +// met: +// +// * Redistributions of source code must retain the above copyright +// notice, this list of conditions and the following disclaimer. +// * Redistributions in binary form must reproduce the above +// copyright notice, this list of conditions and the following +// disclaimer in the documentation and/or other materials provided +// with the distribution. +// * Neither the name of Google Inc. nor the names of its +// contributors may be used to endorse or promote products derived +// from this software without specific prior written permission. +// +// THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +// "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +// LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR +// A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT +// OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, +// SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT +// LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, +// DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY +// THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +// (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +// OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + +// Test that we can create arrays of any size. +for (var i = 1000; i < 1000000; i += 97) { + new Array(i); +}