AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[snapshot] Remove obsolete code modification scope.

Browse Source 
R=hpayer@chromium.org
BUG=v8:6792,chromium:787813

Change-Id: I98af2eb8d9e5f3be1bc5807363545a7d89500ef3
Reviewed-on: https://chromium-review.googlesource.com/787712
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#49616}
This commit is contained in:
Michael Starzinger 2017-11-23 14:07:14 +01:00 committed by Commit Bot
parent 13a68e6c29
commit 12633726a2
2 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/snapshot/code-serializer.cc
View File

@ -243,6 +243,8 @@ MaybeHandle<FixedArray> WasmCompiledModuleSerializer::DeserializeWasmModule(
return nothing; return nothing;
} }
// TODO(6792): No longer needed once WebAssembly code is off heap.
CodeSpaceMemoryModificationScope modification_scope(isolate->heap());
MaybeHandle<WasmCompiledModule> maybe_result = MaybeHandle<WasmCompiledModule> maybe_result =
ObjectDeserializer::DeserializeWasmCompiledModule(isolate, &scd, ObjectDeserializer::DeserializeWasmCompiledModule(isolate, &scd,
wire_bytes); wire_bytes);
@ -250,8 +252,6 @@ MaybeHandle<FixedArray> WasmCompiledModuleSerializer::DeserializeWasmModule(
Handle<WasmCompiledModule> result; Handle<WasmCompiledModule> result;
if (!maybe_result.ToHandle(&result)) return nothing; if (!maybe_result.ToHandle(&result)) return nothing;
// TODO(6792): No longer needed once WebAssembly code is off heap.
CodeSpaceMemoryModificationScope modification_scope(isolate->heap());
WasmCompiledModule::ReinitializeAfterDeserialization(isolate, result); WasmCompiledModule::ReinitializeAfterDeserialization(isolate, result);
DCHECK(WasmCompiledModule::IsWasmCompiledModule(*result)); DCHECK(WasmCompiledModule::IsWasmCompiledModule(*result));
return result; return result;

2
src/snapshot/object-deserializer.cc
View File

@ -68,8 +68,6 @@ ObjectDeserializer::DeserializeWasmCompiledModule(
MaybeHandle<HeapObject> ObjectDeserializer::Deserialize(Isolate* isolate) { MaybeHandle<HeapObject> ObjectDeserializer::Deserialize(Isolate* isolate) {
Initialize(isolate); Initialize(isolate);
CodeSpaceMemoryModificationScope modification_scope(isolate->heap());
if (!allocator()->ReserveSpace()) return MaybeHandle<HeapObject>(); if (!allocator()->ReserveSpace()) return MaybeHandle<HeapObject>();
DCHECK(deserializing_user_code()); DCHECK(deserializing_user_code());