cppgc: Move implementation headers in internal/ dir

Headers containing only implementation details are better to stay in a
separate dir to indicate the user that they shouldn't be included.

Bug: chromium:1056170
Change-Id: I10f84ddf709b146396aadc820ec33bc6a49b2dac
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2139585
Reviewed-by: Omer Katz <omerkatz@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Anton Bikineev <bikineev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#67050}

BUILD.gn

@@ -3946,11 +3946,11 @@ v8_source_set("cppgc_base") {
 
   sources = [
     "include/cppgc/allocation.h",
-    "include/cppgc/api-constants.h",
-    "include/cppgc/finalizer-trait.h",
     "include/cppgc/garbage-collected.h",
-    "include/cppgc/gc-info.h",
     "include/cppgc/heap.h",
+    "include/cppgc/internal/api-contants.h",
+    "include/cppgc/internal/finalizer-traits.h",
+    "include/cppgc/internal/gc-info.h",
     "include/cppgc/member.h",
     "include/cppgc/platform.h",
     "include/cppgc/source-location.h",

include/cppgc/allocation.h

@@ -9,9 +9,9 @@
 #include <atomic>
 
 #include "include/cppgc/garbage-collected.h"
-#include "include/cppgc/gc-info.h"
 #include "include/cppgc/heap.h"
-#include "include/cppgc/internals.h"
+#include "include/cppgc/internal/api-constants.h"
+#include "include/cppgc/internal/gc-info.h"
 
 namespace cppgc {
 

include/cppgc/garbage-collected.h

@@ -7,7 +7,7 @@
 
 #include <type_traits>
 
-#include "include/cppgc/internals.h"
+#include "include/cppgc/internal/api-constants.h"
 #include "include/cppgc/platform.h"
 #include "include/cppgc/trace-trait.h"
 #include "include/cppgc/type-traits.h"

include/cppgc/internal/api-constants.h

@@ -2,8 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef INCLUDE_CPPGC_INTERNALS_H_
-#define INCLUDE_CPPGC_INTERNALS_H_
+#ifndef INCLUDE_CPPGC_INTERNAL_API_CONSTANTS_H_
+#define INCLUDE_CPPGC_INTERNAL_API_CONSTANTS_H_
 
 #include <stddef.h>
 #include <stdint.h>
@@ -32,4 +32,4 @@ static constexpr size_t kLargeObjectSizeThreshold = 65536;
 }  // namespace internal
 }  // namespace cppgc
 
-#endif  // INCLUDE_CPPGC_INTERNALS_H_
+#endif  // INCLUDE_CPPGC_INTERNAL_API_CONSTANTS_H_

include/cppgc/internal/finalizer-trait.h

@@ -2,8 +2,8 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef INCLUDE_CPPGC_FINALIZER_TRAIT_H_
-#define INCLUDE_CPPGC_FINALIZER_TRAIT_H_
+#ifndef INCLUDE_CPPGC_INTERNAL_FINALIZER_TRAIT_H_
+#define INCLUDE_CPPGC_INTERNAL_FINALIZER_TRAIT_H_
 
 #include <type_traits>
 
@@ -87,4 +87,4 @@ constexpr FinalizationCallback FinalizerTrait<T>::kCallback;
 }  // namespace internal
 }  // namespace cppgc
 
-#endif  // INCLUDE_CPPGC_FINALIZER_TRAIT_H_
+#endif  // INCLUDE_CPPGC_INTERNAL_FINALIZER_TRAIT_H_

include/cppgc/internal/gc-info.h

@@ -2,12 +2,12 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef INCLUDE_CPPGC_GC_INFO_H_
-#define INCLUDE_CPPGC_GC_INFO_H_
+#ifndef INCLUDE_CPPGC_INTERNAL_GC_INFO_H_
+#define INCLUDE_CPPGC_INTERNAL_GC_INFO_H_
 
 #include <stdint.h>
 
-#include "include/cppgc/finalizer-trait.h"
+#include "include/cppgc/internal/finalizer-trait.h"
 #include "include/v8config.h"
 
 namespace cppgc {
@@ -40,4 +40,4 @@ struct GCInfoTrait {
 }  // namespace internal
 }  // namespace cppgc
 
-#endif  // INCLUDE_CPPGC_GC_INFO_H_
+#endif  // INCLUDE_CPPGC_INTERNAL_GC_INFO_H_

src/heap/cppgc/gc-info-table.cc

@@ -8,7 +8,7 @@
 #include <limits>
 #include <memory>
 
-#include "include/cppgc/gc-info.h"
+#include "include/cppgc/internal/gc-info.h"
 #include "include/cppgc/platform.h"
 #include "src/base/bits.h"
 #include "src/base/lazy-instance.h"

src/heap/cppgc/gc-info-table.h

@@ -7,7 +7,7 @@
 
 #include <stdint.h>
 
-#include "include/cppgc/gc-info.h"
+#include "include/cppgc/internal/gc-info.h"
 #include "include/cppgc/platform.h"
 #include "include/v8config.h"
 #include "src/base/logging.h"

src/heap/cppgc/gc-info.cc

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "include/cppgc/gc-info.h"
+#include "include/cppgc/internal/gc-info.h"
 #include "include/v8config.h"
 #include "src/heap/cppgc/gc-info-table.h"
 

src/heap/cppgc/heap-object-header-inl.h

@@ -6,7 +6,7 @@
 #define V8_HEAP_CPPGC_HEAP_OBJECT_HEADER_INL_H_
 
 #include "include/cppgc/allocation.h"
-#include "include/cppgc/gc-info.h"
+#include "include/cppgc/internal/gc-info.h"
 #include "src/base/atomic-utils.h"
 #include "src/base/logging.h"
 #include "src/base/macros.h"

src/heap/cppgc/heap-object-header.cc

@@ -4,7 +4,7 @@
 
 #include "src/heap/cppgc/heap-object-header.h"
 
-#include "include/cppgc/internals.h"
+#include "include/cppgc/internal/api-constants.h"
 #include "src/base/macros.h"
 #include "src/heap/cppgc/gc-info-table.h"
 #include "src/heap/cppgc/heap-object-header-inl.h"

src/heap/cppgc/heap-object-header.h

@@ -8,7 +8,7 @@
 #include <stdint.h>
 #include <atomic>
 
-#include "include/cppgc/gc-info.h"
+#include "include/cppgc/internal/gc-info.h"
 #include "src/base/bit-field.h"
 #include "src/heap/cppgc/globals.h"
 

src/heap/cppgc/heap.h

@@ -8,8 +8,8 @@
 #include <memory>
 #include <vector>
 
-#include "include/cppgc/gc-info.h"
 #include "include/cppgc/heap.h"
+#include "include/cppgc/internal/gc-info.h"
 #include "src/heap/cppgc/heap-object-header.h"
 
 namespace cppgc {

test/unittests/heap/cppgc/finalizer-trait_unittest.cc

@@ -2,8 +2,9 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "include/cppgc/finalizer-trait.h"
 #include <type_traits>
+
+#include "include/cppgc/internal/finalizer-trait.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace cppgc {

test/unittests/heap/cppgc/gc-info_unittest.cc

@@ -2,7 +2,7 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "include/cppgc/gc-info.h"
+#include "include/cppgc/internal/gc-info.h"
 
 #include "include/cppgc/platform.h"
 #include "src/base/page-allocator.h"