AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert "Ship the relative indexing method .at"

Browse Source 
This reverts commit 46628795f1.

Reason for revert: Compat breakage

Bug: chromium:1170196

Original change's description:
> Ship the relative indexing method `.at`
>
> I2S with LGTMs:
> https://groups.google.com/a/chromium.org/g/blink-dev/c/I8S78w7aFmE/m/qLHAcjhRCQAJ
>
> v8: 10961
> Change-Id: If0440c0595823c61352f144c1fc29c54a1175623
> Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2574716
> Reviewed-by: Marja Hölttä <marja@chromium.org>
> Commit-Queue: Shu-yu Guo <syg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#71619}

TBR=marja@chromium.org,syg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I2384af84100dcf8cb27f10c5d055d7f864ebcbb9
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2646139
Reviewed-by: Shu-yu Guo <syg@chromium.org>
Reviewed-by: Marja Hölttä <marja@chromium.org>
Commit-Queue: Shu-yu Guo <syg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#72279}
This commit is contained in:
Shu-yu Guo 2021-01-24 21:35:52 -08:00 committed by Commit Bot
parent 957d872bf5
commit 13005c319d
2 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/flags/flag-definitions.h
View File

@ -264,8 +264,9 @@ DEFINE_IMPLICATION(harmony_weak_refs_with_cleanup_some, harmony_weak_refs)
#endif
// Features that are complete (but still behind --harmony/es-staging flag).
#define HARMONY_STAGED_BASE(V) \
V(harmony_top_level_await, "harmony top level await")
#define HARMONY_STAGED_BASE(V) \
V(harmony_top_level_await, "harmony top level await") \
V(harmony_relative_indexing_methods, "harmony relative indexing methods")
#ifdef V8_INTL_SUPPORT
#define HARMONY_STAGED(V) \
@ -283,8 +284,7 @@ DEFINE_IMPLICATION(harmony_weak_refs_with_cleanup_some, harmony_weak_refs)
V(harmony_weak_refs, "harmony weak references") \
V(harmony_string_replaceall, "harmony String.prototype.replaceAll") \
V(harmony_logical_assignment, "harmony logical assignment") \
V(harmony_atomics_waitasync, "harmony Atomics.waitAsync") \
V(harmony_relative_indexing_methods, "harmony relative indexing methods")
V(harmony_atomics_waitasync, "harmony Atomics.waitAsync")
#ifdef V8_INTL_SUPPORT
#define HARMONY_SHIPPING(V) HARMONY_SHIPPING_BASE(V)

5
test/test262/test262.status
View File

@ -576,6 +576,11 @@
# http://crbug/v8/10905
'language/identifier-resolution/assign-to-global-undefined': [FAIL],
# https://bugs.chromium.org/p/chromium/issues/detail?id=1159764
'built-ins/Array/prototype/at/*': [FAIL],
'built-ins/String/prototype/at/*': [FAIL],
'built-ins/TypedArray/prototype/at/*': [FAIL],
######################## NEEDS INVESTIGATION ###########################
# https://bugs.chromium.org/p/v8/issues/detail?id=7833