AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Remove set but otherwise unused variables

Browse Source 
Recent Clang versions have enhanced -Wunused-but-set-variable which now
warns about these.

Bug: chromium:1309955
Change-Id: Id99e3eee60bf2c789e15251f65a192a6bf51f252
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3554603
Reviewed-by: Jakob Gruber <jgruber@chromium.org>
Commit-Queue: Jakob Gruber <jgruber@chromium.org>
Cr-Commit-Position: refs/heads/main@{#79645}
This commit is contained in:
Arthur Eubanks 2022-03-28 17:08:27 -07:00 committed by V8 LUCI CQ
parent 7e28b58cd7
commit 133acba828
2 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/compiler/verifier.cc
View File

@ -2138,7 +2138,6 @@ void Verifier::VerifyNode(Node* node) {
bool check_no_control = node->op()->ControlOutputCount() == 0;
bool check_no_effect = node->op()->EffectOutputCount() == 0;
bool check_no_frame_state = node->opcode() != IrOpcode::kFrameState;
int effect_edges = 0;
if (check_no_effect || check_no_control) {
for (Edge edge : node->use_edges()) {
Node* const user = edge.from();
@ -2147,7 +2146,6 @@ void Verifier::VerifyNode(Node* node) {
DCHECK(!check_no_control);
} else if (NodeProperties::IsEffectEdge(edge)) {
DCHECK(!check_no_effect);
effect_edges++;
} else if (NodeProperties::IsFrameStateEdge(edge)) {
DCHECK(!check_no_frame_state);
}

2
src/snapshot/read-only-deserializer.cc
View File

@ -37,7 +37,7 @@ void ReadOnlyDeserializer::DeserializeIntoIsolate() {
ro_heap->read_only_space()->RepairFreeSpacesAfterDeserialization();
// Deserialize the Read-only Object Cache.
for (size_t i = 0;; ++i) {
for (;;) {
Object* object = ro_heap->ExtendReadOnlyObjectCache();
// During deserialization, the visitor populates the read-only object
// cache and eventually terminates the cache with undefined.