From 13e9525843f5e3e1d3a68139fcbbc94909cb66db Mon Sep 17 00:00:00 2001 From: Junliang Yan Date: Thu, 10 Jun 2021 08:55:36 -0400 Subject: [PATCH] ppc: remove StoreTaggedFieldX Change-Id: Ide62ce4c8ac13e6ae8e417bbe06a28c3772be785 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2953040 Reviewed-by: Milad Fa Commit-Queue: Junliang Yan Cr-Commit-Position: refs/heads/master@{#75083} --- src/codegen/ppc/macro-assembler-ppc.cc | 12 ------------ src/codegen/ppc/macro-assembler-ppc.h | 3 --- src/compiler/backend/ppc/code-generator-ppc.cc | 4 ++-- 3 files changed, 2 insertions(+), 17 deletions(-) diff --git a/src/codegen/ppc/macro-assembler-ppc.cc b/src/codegen/ppc/macro-assembler-ppc.cc index 249deefa0c..7f2d55a64d 100644 --- a/src/codegen/ppc/macro-assembler-ppc.cc +++ b/src/codegen/ppc/macro-assembler-ppc.cc @@ -513,18 +513,6 @@ void TurboAssembler::SmiUntag(Register dst, const MemOperand& src, RCBit rc, SmiUntag(dst, rc); } -void TurboAssembler::StoreTaggedFieldX(const Register& value, - const MemOperand& dst_field_operand, - const Register& scratch) { - if (COMPRESS_POINTERS_BOOL) { - RecordComment("[ StoreTagged"); - stwx(value, dst_field_operand); - RecordComment("]"); - } else { - StoreU64(value, dst_field_operand); - } -} - void TurboAssembler::StoreTaggedField(const Register& value, const MemOperand& dst_field_operand, const Register& scratch) { diff --git a/src/codegen/ppc/macro-assembler-ppc.h b/src/codegen/ppc/macro-assembler-ppc.h index b8b039fcfe..3656d8f9e7 100644 --- a/src/codegen/ppc/macro-assembler-ppc.h +++ b/src/codegen/ppc/macro-assembler-ppc.h @@ -666,9 +666,6 @@ class V8_EXPORT_PRIVATE TurboAssembler : public TurboAssemblerBase { void StoreTaggedField(const Register& value, const MemOperand& dst_field_operand, const Register& scratch = no_reg); - void StoreTaggedFieldX(const Register& value, - const MemOperand& dst_field_operand, - const Register& scratch = no_reg); void DecompressTaggedSigned(Register destination, MemOperand field_operand); void DecompressTaggedSigned(Register destination, Register src); diff --git a/src/compiler/backend/ppc/code-generator-ppc.cc b/src/compiler/backend/ppc/code-generator-ppc.cc index 1ef144d17b..868806c0ac 100644 --- a/src/compiler/backend/ppc/code-generator-ppc.cc +++ b/src/compiler/backend/ppc/code-generator-ppc.cc @@ -1236,7 +1236,7 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction( ool = zone()->New( this, object, offset, value, scratch0, scratch1, mode, DetermineStubCallMode(), &unwinding_info_writer_); - __ StoreTaggedFieldX(value, MemOperand(object, offset), r0); + __ StoreTaggedField(value, MemOperand(object, offset), r0); } if (mode > RecordWriteMode::kValueIsPointer) { __ JumpIfSmi(value, ool->exit()); @@ -3824,7 +3824,7 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction( break; } case kPPC_StoreCompressTagged: { - ASSEMBLE_STORE_INTEGER(StoreTaggedField, StoreTaggedFieldX); + ASSEMBLE_STORE_INTEGER(StoreTaggedField, StoreTaggedField); break; } case kPPC_LoadDecompressTaggedSigned: {