AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

s390: [cleanup] Avoid {Object::operator->}

Browse Source 
Port 878ccb33bd

Original Commit Message:

    This CL was generated by an automatic clang AST rewriter using this
    matcher expression:

      callExpr(
        callee(
          cxxMethodDecl(
            hasName("operator->"),
            ofClass(isSameOrDerivedFrom("v8::internal::Object"))
          )
        ),
        argumentCountIs(1)
      )

    The "->" at the expression location was then rewritten to ".".

R=clemensh@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
BUG=
LOG=N

Change-Id: Ibe92f0332da0e478f213880462b4d3460f8260c0
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627569
Reviewed-by: Junliang Yan <jyan@ca.ibm.com>
Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
Cr-Commit-Position: refs/heads/master@{#61793}
This commit is contained in:
Milad Farazmand 2019-05-23 10:08:41 -04:00 committed by Commit Bot
parent 32e48cf510
commit 157b9181f4
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/s390/assembler-s390-inl.h
View File

@ -150,7 +150,7 @@ void RelocInfo::set_target_object(Heap* heap, HeapObject target,
WriteBarrierMode write_barrier_mode,
ICacheFlushMode icache_flush_mode) {
DCHECK(IsCodeTarget(rmode_) || rmode_ == FULL_EMBEDDED_OBJECT);
Assembler::set_target_address_at(pc_, constant_pool_, target->ptr(),
Assembler::set_target_address_at(pc_, constant_pool_, target.ptr(),
icache_flush_mode);
if (write_barrier_mode == UPDATE_WRITE_BARRIER && !host().is_null()) {
WriteBarrierForCode(host(), this, target);
@ -251,7 +251,7 @@ Address Assembler::target_address_at(Address pc, Address constant_pool) {
void Assembler::deserialization_set_special_target_at(
Address instruction_payload, Code code, Address target) {
set_target_address_at(instruction_payload,
!code.is_null() ? code->constant_pool() : kNullAddress,
!code.is_null() ? code.constant_pool() : kNullAddress,
target);
}

2
src/s390/simulator-s390.cc
View File

@ -427,7 +427,7 @@ void S390Debugger::Debug() {
PrintF(" (smi %d)", Smi::ToInt(obj));
} else if (IsValidHeapObject(current_heap, HeapObject::cast(obj))) {
PrintF(" (");
obj->ShortPrint();
obj.ShortPrint();
PrintF(")");
}
PrintF("\n");