From 15cb93ed6293a0c2ae6564190d41d8f9947c6c78 Mon Sep 17 00:00:00 2001 From: "svenpanne@chromium.org" Date: Wed, 1 Jun 2011 07:11:25 +0000 Subject: [PATCH] Ooops, forgot to commit the renamings in Hydrogen for issue 6976028.... TBR=danno@chromium.org Review URL: http://codereview.chromium.org/7105014 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@8132 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/hydrogen.cc | 16 ++++++++++------ src/hydrogen.h | 4 ++-- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/src/hydrogen.cc b/src/hydrogen.cc index c2b9adc0df..c109133c8f 100644 --- a/src/hydrogen.cc +++ b/src/hydrogen.cc @@ -5093,10 +5093,13 @@ void HGraphBuilder::VisitBinaryOperation(BinaryOperation* expr) { ASSERT(current_block() != NULL); ASSERT(current_block()->HasPredecessor()); switch (expr->op()) { - case Token::COMMA: return VisitComma(expr); - case Token::OR: return VisitAndOr(expr, false); - case Token::AND: return VisitAndOr(expr, true); - default: return VisitCommon(expr); + case Token::COMMA: + return VisitComma(expr); + case Token::OR: + case Token::AND: + return VisitLogicalExpression(expr); + default: + return VisitArithmeticExpression(expr); } } @@ -5109,7 +5112,8 @@ void HGraphBuilder::VisitComma(BinaryOperation* expr) { } -void HGraphBuilder::VisitAndOr(BinaryOperation* expr, bool is_logical_and) { +void HGraphBuilder::VisitLogicalExpression(BinaryOperation* expr) { + bool is_logical_and = expr->op() == Token::AND; if (ast_context()->IsTest()) { TestContext* context = TestContext::cast(ast_context()); // Translate left subexpression. @@ -5196,7 +5200,7 @@ void HGraphBuilder::VisitAndOr(BinaryOperation* expr, bool is_logical_and) { } -void HGraphBuilder::VisitCommon(BinaryOperation* expr) { +void HGraphBuilder::VisitArithmeticExpression(BinaryOperation* expr) { CHECK_ALIVE(VisitForValue(expr->left())); CHECK_ALIVE(VisitForValue(expr->right())); HValue* right = Pop(); diff --git a/src/hydrogen.h b/src/hydrogen.h index e07afbce5a..603480130b 100644 --- a/src/hydrogen.h +++ b/src/hydrogen.h @@ -753,8 +753,8 @@ class HGraphBuilder: public AstVisitor { void VisitNot(UnaryOperation* expr); void VisitComma(BinaryOperation* expr); - void VisitAndOr(BinaryOperation* expr, bool is_logical_and); - void VisitCommon(BinaryOperation* expr); + void VisitLogicalExpression(BinaryOperation* expr); + void VisitArithmeticExpression(BinaryOperation* expr); void PreProcessOsrEntry(IterationStatement* statement); // True iff. we are compiling for OSR and the statement is the entry.