AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

GCC: fix selection of IMMEDIATE_CRASH

Browse Source 
immediate_crash.h still uses V8_CC_GCC define to determine which
IMMEDIATE_CRASH macro is used. This should be V8_CC_GNU instead.
Otherwise weird compile errors are happening with turboshaft.

Bug: chromium:819294
Change-Id: Id77fe7406ae16a804e1e466844f81d6c728ec008
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4111849
Commit-Queue: Stephan Hartmann <stha09@googlemail.com>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/main@{#84923}
This commit is contained in:
Stephan Hartmann 2022-12-18 16:26:02 +01:00 committed by V8 LUCI CQ
parent 5d95bd39ca
commit 15d123009b
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/base/immediate-crash.h
View File

@ -140,9 +140,9 @@
[] { TRAP_SEQUENCE_(); }(); \
} while (false)
#endif // !V8_CC_GCC
#endif // !V8_CC_GNU
#if defined(__clang__) || V8_CC_GCC
#if defined(__clang__) || V8_CC_GNU
// __builtin_unreachable() hints to the compiler that this is noreturn and can
// be packed in the function epilogue.