AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Fix Torque definition of SmallOrderedNameDictionary

Browse Source 
The recently-added verifiers for indexed fields have caught a bug: the
definition of SmallOrderedNameDictionary in Torque contained incorrect
padding for builds without pointer compression.

Bug: v8:11063
Change-Id: I2c3d7f06965ec0598ef4fe56923090aa89bc9df1
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2529013
Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#71156}
This commit is contained in:
Seth Brenith 2020-11-10 10:42:18 -08:00 committed by Commit Bot
parent cdcf3c3134
commit 15f8f64755
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/objects/ordered-hash-table.tq
View File

@ -99,10 +99,13 @@ struct NameDictionaryEntry {
extern class SmallOrderedNameDictionary extends SmallOrderedHashTable {
hash: int32;
@if(TAGGED_SIZE_8_BYTES) padding_0: int32;
@ifnot(TAGGED_SIZE_8_BYTES) padding_0: void;
number_of_elements: uint8;
number_of_deleted_elements: uint8;
const number_of_buckets: uint8;
padding: uint8;
@if(TAGGED_SIZE_8_BYTES) padding_1[5]: uint8;
@ifnot(TAGGED_SIZE_8_BYTES) padding_1[1]: uint8;
data_table[Convert<intptr>(number_of_buckets) * kSmallOrderedHashTableLoadFactor]:
NameDictionaryEntry;
hash_table[number_of_buckets]: uint8;