AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[gyp] Disable warnings generated by third party ICU code.

Browse Source 
R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/962523002

Cr-Commit-Position: refs/heads/master@{#26871}
This commit is contained in:
bmeurer 2015-02-26 00:19:27 -08:00 committed by Commit bot
parent 0f783c676b
commit 166dcd339f
1 changed files with 25 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
build/standalone.gypi
View File

@ -199,8 +199,33 @@
],
'conditions': [
['os_posix == 1 and OS != "mac"', {
# We don't want to get warnings from third-party code,
# so remove any existing warning-enabling flags like -Wall.
'cflags!': [
'-pedantic',
'-Wall',
'-Werror',
'-Wextra',
],
'cflags+': [
# Clang considers the `register` keyword as deprecated, but
# ICU uses it all over the place.
'-Wno-deprecated-register',
# ICU uses its own deprecated functions.
'-Wno-deprecated-declarations',
# ICU prefers `a && b || c` over `(a && b) || c`.
'-Wno-logical-op-parentheses',
# ICU has some `unsigned < 0` checks.
'-Wno-tautological-compare',
# uresdata.c has switch(RES_GET_TYPE(x)) code. The
# RES_GET_TYPE macro returns an UResType enum, but some switch
# statement contains case values that aren't part of that
# enum (e.g. URES_TABLE32 which is in UResInternalType). This
# is on purpose.
'-Wno-switch',
],
'cflags_cc!': [
'-Wnon-virtual-dtor',
],
}],
['OS == "mac"', {
@ -286,7 +311,6 @@
'cflags': [
'-Wall',
'<(werror)',
'-W',
'-Wno-unused-parameter',
'-Wno-long-long',
'-pthread',
@ -317,7 +341,6 @@
'cflags': [
'-Wall',
'<(werror)',
'-W',
'-Wno-unused-parameter',
'-fno-exceptions',
# Don't warn about the "struct foo f = {0};" initialization pattern.
@ -460,7 +483,6 @@
'WARNING_CFLAGS': [
'-Wall',
'-Wendif-labels',
'-W',
'-Wno-unused-parameter',
# Don't warn about the "struct foo f = {0};" initialization pattern.
'-Wno-missing-field-initializers',