From 166fd2f38f44dec856367eda95bd3bdcc4b4644f Mon Sep 17 00:00:00 2001 From: gengjiawen Date: Sat, 31 Dec 2022 22:55:24 -0800 Subject: [PATCH] [cppgc]: Fix build on msvc Fixes compilation with msvc 2019 toolchain. See: nodejs/node#37330 (comment) Bug: v8:12661 Change-Id: I7cfd87a3dd531a2e4913d82b743fb8ecdfdb5ed8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3533019 Reviewed-by: Michael Lippautz Commit-Queue: Michael Lippautz Cr-Commit-Position: refs/heads/main@{#85087} --- include/v8-cppgc.h | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/include/v8-cppgc.h b/include/v8-cppgc.h index 139af8fdac..4a457027c9 100644 --- a/include/v8-cppgc.h +++ b/include/v8-cppgc.h @@ -77,6 +77,15 @@ struct WrapperDescriptor final { }; struct V8_EXPORT CppHeapCreateParams { + CppHeapCreateParams( + std::vector> custom_spaces, + WrapperDescriptor wrapper_descriptor) + : custom_spaces(std::move(custom_spaces)), + wrapper_descriptor(wrapper_descriptor) {} + + CppHeapCreateParams(const CppHeapCreateParams&) = delete; + CppHeapCreateParams& operator=(const CppHeapCreateParams&) = delete; + std::vector> custom_spaces; WrapperDescriptor wrapper_descriptor; /**