AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Revert of [build] Switch off warning on gcc bots. (patchset #2 id:20001 of https://codereview.chromium.org/2425913002/ )

Browse Source 
Reason for revert:
Seems to be the wrong flag:
https://build.chromium.org/p/client.v8.ports/builders/V8%20Mips%20-%20builder/builds/4709

Original issue's description:
> [build] Switch off warning on gcc bots.
>
> Switch off maybe-uninitialized warning as it gives often
> false positives with optimizations in gcc.
>
> NOTRY=true
> TBR=bmeurer@chromium.org, zhengxing.li@intel.com, caitp@igalia.com, ahaas@chromium.org
>
> Committed: https://crrev.com/0ef0d5b2b8cffd1e3647d79c5ba19752bbbc469c
> Cr-Commit-Position: refs/heads/master@{#40382}

TBR=bmeurer@chromium.org,zhengxing.li@intel.com,caitp@igalia.com,ahaas@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2422103006
Cr-Commit-Position: refs/heads/master@{#40385}
This commit is contained in:
machenbach 2016-10-18 01:02:55 -07:00 committed by Commit bot
parent 85844420a2
commit 179436cf8c
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
gypfiles/standalone.gypi
View File

@ -503,10 +503,7 @@
},
'conditions':[
['clang==0', {
'cflags+': [
'-Wno-sign-compare',
'-Wno-maybe-uninitialized',
],
'cflags+': ['-Wno-sign-compare',],
}],
['clang==1 or host_clang==1', {
# This is here so that all files get recompiled after a clang roll and