AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[inspector] fix compilation on win and linux

Browse Source 
BUG=chromium:635948
R=dgozman@chromium.org,machenbach@chromium.org

Review-Url: https://codereview.chromium.org/2389133004
Cr-Commit-Position: refs/heads/master@{#40003}
This commit is contained in:
kozyatinskiy 2016-10-05 10:07:24 -07:00 committed by Commit bot
parent 7e237ad3c8
commit 186e7db8dd
3 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/inspector/string-16.cc
View File

@ -375,7 +375,7 @@ String16 String16::fromInteger(int number) {
String16 String16::fromInteger(size_t number) {
const size_t kBufferSize = 50;
char buffer[kBufferSize];
std::snprintf(buffer, kBufferSize, "%zu", number);
v8::base::OS::SNPrintF(buffer, kBufferSize, "%zu", number);
return String16(buffer);
}

1
test/inspector/inspector-test.cc
View File

@ -127,7 +127,6 @@ class SetTimeoutExtension : public v8::Extension {
private:
static void SetTimeout(const v8::FunctionCallbackInfo<v8::Value>& args) {
v8::Isolate* isolate = args.GetIsolate();
if (args.Length() != 2 || !args[1]->IsNumber() ||
(!args[0]->IsFunction() && !args[0]->IsString()) ||
args[1].As<v8::Number>()->Value() != 0.0) {

2
test/inspector/task-runner.cc
View File

@ -132,7 +132,7 @@ void ExecuteStringTask::Run(v8::Isolate* isolate,
v8::Local<v8::String> source =
v8::String::NewFromTwoByte(isolate, expression_.characters16(),
v8::NewStringType::kNormal,
expression_.length())
static_cast<int>(expression_.length()))
.ToLocalChecked();
v8::ScriptCompiler::Source scriptSource(source, origin);