AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

[wasm] Allow use of full wasm code space

Browse Source 
On system which required a contiguous code range, we currently limit
the committed wasm code space to the heap code space. Since
https://crrev.com/c/1044195, this was only 128MB, making bigger
benchmarks fail.
There is no need to link the two limits, thus just remove that logic.

R=titzer@chromium.org

Change-Id: Id61f5dd28c96c3d2b7fcd730751285c6fc144bc5
Reviewed-on: https://chromium-review.googlesource.com/1049648
Reviewed-by: Ben Titzer <titzer@chromium.org>
Reviewed-by: Hannes Payer <hpayer@chromium.org>
Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#53059}
This commit is contained in:
Clemens Hammacher 2018-05-08 12:07:16 +02:00 committed by Commit Bot
parent fe91e0bd69
commit 1871c8c52b
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/isolate.cc
View File

@ -3007,14 +3007,9 @@ bool Isolate::Init(StartupDeserializer* des) {
}
// Setup the wasm engine. Currently, there's one per Isolate.
const size_t max_code_size =
kRequiresCodeRange
? std::min(kMaxWasmCodeMemory,
heap_.memory_allocator()->code_range()->size())
: kMaxWasmCodeMemory;
wasm_engine_.reset(new wasm::WasmEngine(
std::unique_ptr<wasm::WasmCodeManager>(new wasm::WasmCodeManager(
reinterpret_cast<v8::Isolate*>(this), max_code_size))));
reinterpret_cast<v8::Isolate*>(this), kMaxWasmCodeMemory))));
wasm_engine_->memory_tracker()->SetAllocationResultHistogram(
counters()->wasm_memory_allocation_result());
wasm_engine_->memory_tracker()->SetAddressSpaceUsageHistogram(