From 18a0a9746f3147950eaca355ca4a5d5d08e15552 Mon Sep 17 00:00:00 2001 From: Michael Starzinger Date: Wed, 8 Aug 2018 11:16:01 +0200 Subject: [PATCH] [cleanup] Remove some dead MacroAssembler enums. R=sigurds@chromium.org Change-Id: I2f8210a386fa39030c7ffe4c7d0f25bd845c612a Reviewed-on: https://chromium-review.googlesource.com/1166908 Commit-Queue: Sigurd Schneider Reviewed-by: Sigurd Schneider Cr-Commit-Position: refs/heads/master@{#54964} --- src/arm/macro-assembler-arm.h | 9 --------- src/ia32/macro-assembler-ia32.h | 2 -- src/mips/macro-assembler-mips.h | 9 --------- src/mips64/macro-assembler-mips64.h | 9 --------- src/ppc/macro-assembler-ppc.h | 10 ---------- src/s390/macro-assembler-s390.h | 8 -------- src/x64/macro-assembler-x64.h | 3 --- 7 files changed, 50 deletions(-) diff --git a/src/arm/macro-assembler-arm.h b/src/arm/macro-assembler-arm.h index 202f70bddc..8286c8d304 100644 --- a/src/arm/macro-assembler-arm.h +++ b/src/arm/macro-assembler-arm.h @@ -51,15 +51,6 @@ inline MemOperand FieldMemOperand(Register object, int offset) { constexpr Register cp = r7; // JavaScript context pointer. constexpr Register kRootRegister = r10; // Roots array pointer. -// Flags used for AllocateHeapNumber -enum TaggingMode { - // Tag the result. - TAG_RESULT, - // Don't tag - DONT_TAG_RESULT -}; - - enum RememberedSetAction { EMIT_REMEMBERED_SET, OMIT_REMEMBERED_SET }; enum SmiCheck { INLINE_SMI_CHECK, OMIT_SMI_CHECK }; enum LinkRegisterStatus { kLRHasNotBeenSaved, kLRHasBeenSaved }; diff --git a/src/ia32/macro-assembler-ia32.h b/src/ia32/macro-assembler-ia32.h index a7f39971c6..ae8075aa6f 100644 --- a/src/ia32/macro-assembler-ia32.h +++ b/src/ia32/macro-assembler-ia32.h @@ -45,8 +45,6 @@ typedef Operand MemOperand; enum RememberedSetAction { EMIT_REMEMBERED_SET, OMIT_REMEMBERED_SET }; enum SmiCheck { INLINE_SMI_CHECK, OMIT_SMI_CHECK }; -enum RegisterValueType { REGISTER_VALUE_IS_SMI, REGISTER_VALUE_IS_INT32 }; - #ifdef DEBUG bool AreAliased(Register reg1, Register reg2, Register reg3 = no_reg, Register reg4 = no_reg, Register reg5 = no_reg, diff --git a/src/mips/macro-assembler-mips.h b/src/mips/macro-assembler-mips.h index 402b28265c..5b6e6dd0b2 100644 --- a/src/mips/macro-assembler-mips.h +++ b/src/mips/macro-assembler-mips.h @@ -39,7 +39,6 @@ constexpr Register kWasmInstanceRegister = a0; // Forward declarations enum class AbortReason; -class JumpTarget; // Reserved Register Usage Summary. // @@ -60,14 +59,6 @@ enum LeaveExitFrameMode { NO_EMIT_RETURN = false }; -// Flags used for AllocateHeapNumber -enum TaggingMode { - // Tag the result. - TAG_RESULT, - // Don't tag - DONT_TAG_RESULT -}; - // Allow programmer to use Branch Delay Slot of Branches, Jumps, Calls. enum BranchDelaySlot { USE_DELAY_SLOT, diff --git a/src/mips64/macro-assembler-mips64.h b/src/mips64/macro-assembler-mips64.h index 260a2a9aeb..fc0d139239 100644 --- a/src/mips64/macro-assembler-mips64.h +++ b/src/mips64/macro-assembler-mips64.h @@ -39,7 +39,6 @@ constexpr Register kWasmInstanceRegister = a0; // Forward declarations. enum class AbortReason; -class JumpTarget; // Reserved Register Usage Summary. // @@ -60,14 +59,6 @@ enum LeaveExitFrameMode { NO_EMIT_RETURN = false }; -// Flags used for AllocateHeapNumber -enum TaggingMode { - // Tag the result. - TAG_RESULT, - // Don't tag - DONT_TAG_RESULT -}; - // Allow programmer to use Branch Delay Slot of Branches, Jumps, Calls. enum BranchDelaySlot { USE_DELAY_SLOT, diff --git a/src/ppc/macro-assembler-ppc.h b/src/ppc/macro-assembler-ppc.h index 1c6206b035..1d9257fda5 100644 --- a/src/ppc/macro-assembler-ppc.h +++ b/src/ppc/macro-assembler-ppc.h @@ -47,16 +47,6 @@ inline MemOperand FieldMemOperand(Register object, int offset) { return MemOperand(object, offset - kHeapObjectTag); } - -// Flags used for AllocateHeapNumber -enum TaggingMode { - // Tag the result. - TAG_RESULT, - // Don't tag - DONT_TAG_RESULT -}; - - enum RememberedSetAction { EMIT_REMEMBERED_SET, OMIT_REMEMBERED_SET }; enum SmiCheck { INLINE_SMI_CHECK, OMIT_SMI_CHECK }; enum LinkRegisterStatus { kLRHasNotBeenSaved, kLRHasBeenSaved }; diff --git a/src/s390/macro-assembler-s390.h b/src/s390/macro-assembler-s390.h index 41284732d4..ea587a4738 100644 --- a/src/s390/macro-assembler-s390.h +++ b/src/s390/macro-assembler-s390.h @@ -56,14 +56,6 @@ inline MemOperand RootMemOperand(Heap::RootListIndex index) { return MemOperand(kRootRegister, index << kPointerSizeLog2); } -// Flags used for AllocateHeapNumber -enum TaggingMode { - // Tag the result. - TAG_RESULT, - // Don't tag - DONT_TAG_RESULT -}; - enum RememberedSetAction { EMIT_REMEMBERED_SET, OMIT_REMEMBERED_SET }; enum SmiCheck { INLINE_SMI_CHECK, OMIT_SMI_CHECK }; enum LinkRegisterStatus { kLRHasNotBeenSaved, kLRHasBeenSaved }; diff --git a/src/x64/macro-assembler-x64.h b/src/x64/macro-assembler-x64.h index d7a0f06bfa..4e0a14b0ec 100644 --- a/src/x64/macro-assembler-x64.h +++ b/src/x64/macro-assembler-x64.h @@ -63,9 +63,6 @@ bool AreAliased(Register reg1, Register reg8 = no_reg); #endif -// Forward declaration. -class JumpTarget; - struct SmiIndex { SmiIndex(Register index_register, ScaleFactor scale) : reg(index_register),