AuroraMiddleware/v8
1
0
Fork 0
Code Issues 2 Pull Requests Releases Wiki Activity

Remove always-true --fast-calls-with-arguments-mismatches flag

Browse Source 
This feature shipped in V8 v7.4:
https://v8.dev/blog/v8-release-74#faster-calls-with-arguments-mismatch

Bug: v8:8895
Change-Id: I55c50aeda6c61d07b37987404ea09266c9f66702
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1762026
Reviewed-by: Sathya Gunasekaran  <gsathya@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#63287}
This commit is contained in:
Mathias Bynens 2019-08-20 15:57:59 +02:00 committed by Commit Bot
parent cc65464029
commit 18c4164e93
2 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/ast/ast.cc
View File

@ -217,13 +217,7 @@ bool FunctionLiteral::AllowsLazyCompilation() {
}
bool FunctionLiteral::SafeToSkipArgumentsAdaptor() const {
// TODO(bmeurer,verwaest): The --fast_calls_with_arguments_mismatches
// is mostly here for checking the real-world impact of the calling
// convention. There's not really a point in turning off this flag
// otherwise, so we should remove it at some point, when we're done
// with the experiments (https://crbug.com/v8/8895).
return FLAG_fast_calls_with_arguments_mismatches &&
language_mode() == LanguageMode::kStrict &&
return language_mode() == LanguageMode::kStrict &&
scope()->arguments() == nullptr &&
scope()->rest_parameter() == nullptr;
}

4
src/flags/flag-definitions.h
View File

@ -384,10 +384,6 @@ DEFINE_BOOL(feedback_normalization, false,
DEFINE_BOOL_READONLY(internalize_on_the_fly, true,
"internalize string keys for generic keyed ICs on the fly")
// Flag to faster calls with arguments mismatches (https://crbug.com/v8/8895)
DEFINE_BOOL(fast_calls_with_arguments_mismatches, true,
"skip arguments adaptor frames when it's provably safe")
// Flag for one shot optimiztions.
DEFINE_BOOL(enable_one_shot_optimization, true,
"Enable size optimizations for the code that will "